Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on our libevent, build all with CMake, general clean-up #72

Merged
merged 22 commits into from
Jun 4, 2023
Merged

Rely on our libevent, build all with CMake, general clean-up #72

merged 22 commits into from
Jun 4, 2023

Conversation

h-vetinari
Copy link
Member

Fixes #68
Fixes #42
Fixes #35

Also adding myself to maintainers.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'thrift-cpp' output doesn't have any tests.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

h-vetinari commented May 24, 2023 •
edited
Loading

Exploring flex-on-windows in conda-forge/flex-feedstock#30

Not necessary since there's https://github.com/conda-forge/winflexbison-feedstock/ 🙃

@h-vetinari h-vetinari force-pushed the cmake branch 4 times, most recently from 96153f0 to 9cad3ba Compare June 2, 2023 13:00
h-vetinari added 20 commits June 3, 2023 09:48
@h-vetinari
recipe cosmetics
89bc8b6
@h-vetinari
rebase patch, put it in separate folder, simplify it
3998088 
simplified by using `#undef interface` and setting `-DNOMINMAX`
@h-vetinari
remove obsolete openssl-distinction of wrapper output
013bf25
@h-vetinari
depend on conda-forge's libevent also on windows
520432f
@h-vetinari
remove deprecated CMake option
8e38502
@h-vetinari
switch to pure CMake build on unix
1c4ff43
@h-vetinari
remove duplicate invocation of CMake in build.sh
ca23e20 
reason this previously didn't work is most likely a sneaky
non-breaking space that managed to break correct detection
of the string "OFF"
@h-vetinari
harmonize build & install invocations through CMake
e6143ba
@h-vetinari
prettify windows build scripts
c8855c3
@h-vetinari
bump build number
177642e
@h-vetinari
add myself to maintainers
e50eb49
@h-vetinari
MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…
5a48e37 
…nda-forge-pinning 2023.05.24.03.17.19
@h-vetinari
ensure correct installation location on windows
f43177e 
following apache/thrift@66d110b,
which makes some choices that are not applicable to our setup
@h-vetinari
clarify and clean up testing
6a01d66
@h-vetinari
add CMake integration test
34e241f
@h-vetinari
build from scratch on windows
51f0539
@h-vetinari
simplify build deps of outputs
07dd6c5
@h-vetinari
use winflexbison on windows
3e7eeb2 
also use pkg-config as a fall-back on windows
@h-vetinari
patch in implementation of boost::throw_exception
9e14d8a
@h-vetinari
add a test-dep to pass CMake integration test on windows
82a4933
@h-vetinari h-vetinari marked this pull request as ready for review June 3, 2023 00:04
@h-vetinari
Copy link
Member Author

@conda-forge/thrift-cpp
This should be ready now. It's a pretty substantial overhaul and fixes a lot of pain points (e.g. CMake & pkg-config metadata incl. tests, reusing our libevent implementation, not relying on third-party bison/flex, building from scratch also on windows).

I structured the commits to make sense individually, so I ask to not squash this please. I'm also adding myself to maintainers.

PTAL :)

@xhochy xhochy merged commit 7b04edc into conda-forge:main Jun 4, 2023
@h-vetinari h-vetinari deleted the cmake branch June 4, 2023 21:36
@h-vetinari h-vetinari mentioned this pull request Jun 16, 2023
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@wesm wesm Awaiting requested review from wesm wesm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@h-vetinari @xhochy