TBB 2019.0 with VS2008 fix #35
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Removing python-tbb entry point - it behaves incorrectly yet
recipe/meta.yaml
Outdated
| - set INCLUDE=%INCLUDE%;%LIBRARY_INC% # [win] | ||
| - set LIB=%LIB%;%LIBRARY_LIB% # [win] | ||
| - nmake /f Makefile.windows # [win] | ||
| - make -C examples/test_all/fibonacci CXXFLAGS="-I$PREFIX/include -L$PREFIX/lib" # [unix] |
There was a problem hiding this comment.
The fact that conda-build requires include and library directories settings to be explicit was unexpected. Am I doing something wrong with the compiler in the test requirements?
There was a problem hiding this comment.
The Makefile doesn't make use of CPPFLAGS and uses only CXXFLAGS. Toolchain adds -I$PREFIX/include to CPPFLAGS and not CXXFLAGS.
There was a problem hiding this comment.
Thanks, I see. What's about the same question on Windows?
There was a problem hiding this comment.
INCLUDE and LIB are not set in https://github.com/AnacondaRecipes/aggregate/blob/master/vs2015/activate.bat . You'll have to open an issue in that repo asking them to set INCLUDE and LIB
There was a problem hiding this comment.
Thanks! Also, w.r.t. CPPFLAGS which is the pre-processor flags only.. what's supplying -L flag or sets LIBRARY_PATH?
There was a problem hiding this comment.
LDFLAGS should have -L$PREFIX/lib
|
The build is green now! However, I've noticed a problem with debug libraries within |
|
It is ready for merge: builds are green and the issue with the debug binaries is worked-around. Does anybody want to review this PR? Please review soon or express your intention to review so I'll know whom to wait. |
Updating to TBB version 2019.0 along with the following changes in the recipe:
python -m tbb)tbb-develinstead of simple checks for files existencerun_exportsection andmakeas a build dependency on [unix]Checklist
0(if the version changed)conda-smithyReplaces #34