Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenBLAS #364

Merged
merged 37 commits into from
Apr 28, 2016
Merged

Add OpenBLAS #364

merged 37 commits into from
Apr 28, 2016

Conversation

jakirkham
Copy link
Member

Attempts to add a recipe to build OpenBLAS based off my own version and conda-recipes to some extent. Also, cleaned up a bit to fit here.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/openblas) and found it was in an excellent condition.

@jakirkham jakirkham force-pushed the add_openblas branch 4 times, most recently from 3a950d4 to a04c28a Compare April 14, 2016 22:58
@jakirkham jakirkham force-pushed the add_openblas branch 14 times, most recently from 6a4a55a to 1bb9fdc Compare April 15, 2016 00:38
@jakirkham jakirkham force-pushed the add_openblas branch 2 times, most recently from ab4ee03 to 80c4813 Compare April 15, 2016 01:27
@jakirkham
Copy link
Member Author

I don't think the LAPACK portion of OpenBLAS builds on Windows when using CMake. That's what all these errors are about. We can either build with compilers from MinGW, MSYS2, or similar and create a static library or we can just not support LAPACK and continue building with CMake.

On Travis CI we get too many warnings overrunning the log limit, but when we try to silence them it kills the build because it is too quiet. Can't win. 😦

Linux is failing because it can't figure out what to do with some of the assembly instructions. According to one user, this was fixed by using a newer version of binutils.

@jakirkham jakirkham force-pushed the add_openblas branch 2 times, most recently from 99b8578 to cd971c7 Compare April 27, 2016 19:52
@jakirkham jakirkham changed the title WIP: Add OpenBLAS Add OpenBLAS Apr 27, 2016
@jakirkham
Copy link
Member Author

So, I have made some changes.

  • Disabled Windows (looks like this will be better solved in the feedstock).
  • Added a workaround for Mac (seems to be working).
  • Disabled threading (this a complex issue, but for now feels like the right starting point).

@jakirkham
Copy link
Member Author

Linkage issues on Mac. Take a look at these lines in the log on Travis.

@jakirkham jakirkham force-pushed the add_openblas branch 2 times, most recently from f058f86 to 8b3b1fe Compare April 28, 2016 14:51
@jakirkham
Copy link
Member Author

jakirkham commented Apr 28, 2016 •
edited
Loading

HA! We're getting somewhere. Now it only fails to after the build on Travis. 😆

@jakirkham jakirkham force-pushed the add_openblas branch 2 times, most recently from ca1e918 to da91d71 Compare April 28, 2016 16:11
@jakirkham
Copy link
Member Author

jakirkham commented Apr 28, 2016 •
edited
Loading

🎉 It builds! 🎉

Considering how long this build takes and all the comments seem to be addressed, I'm taking this over to a feedstock.

Note this no longer has any of the CI changes in it. This only has the recipe.

Windows will be dealt with at the feedstock (probably after some discussion at tomorrow's meeting).

Thanks everyone for your help.

@jakirkham jakirkham merged commit 7d2a59a into conda-forge:master Apr 28, 2016
@jakirkham jakirkham deleted the add_openblas branch April 28, 2016 16:51
@jakirkham
Copy link
Member Author

BTW here is the OpenBLAS feedstock.

@jakirkham jakirkham mentioned this pull request Apr 28, 2016
Closed
@jakirkham
Copy link
Member Author

Mac and Linux packages available from the conda-forge channel.

@jakirkham
Copy link
Member Author

Discussion on Windows builds can proceed on this issue ( conda-forge/openblas-feedstock#2 ) to keep things simpler and easier to follow.

@jakirkham
Copy link
Member Author

Cc'd some interested individuals on the Windows build issue for OpenBLAS. We would love to hear your thoughts there.

This was referenced May 20, 2016
Closed
Merged
@jakirkham jakirkham mentioned this pull request Jul 5, 2016
Merged
@ostueker ostueker mentioned this pull request Feb 27, 2017
Open
@rdinnager rdinnager mentioned this pull request Dec 16, 2021
Closed
@jaimergp jaimergp mentioned this pull request Jan 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.