Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recipe for gradient-agreement-filtering #28728

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sarthakpati
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 31, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gradient-agreement-filtering/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/gradient-agreement-filtering/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package gradient-agreement-filtering using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12560338106. Examine the logs at this URL for more detail.

@sarthakpati
Copy link
Contributor Author

@conda-forge/help-python please review

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gradient-agreement-filtering/meta.yaml) and found it was in an excellent condition.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 3, 2025

macOS is failing with:

import: 'gradient_agreement_filtering'
Traceback (most recent call last):
  File "/Users/runner/bld/gradient-agreement-filtering_1735654061558/test_tmp/run_test.py", line 2, in <module>
    import gradient_agreement_filtering
  File "/Users/runner/bld/gradient-agreement-filtering_1735654061558/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.9/site-packages/gradient_agreement_filtering.py", line 21, in <module>
    import torch
  File "/Users/runner/bld/gradient-agreement-filtering_1735654061558/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.9/site-packages/torch/__init__.py", line 367, in <module>
    from torch._C import *  # noqa: F403
ImportError: dlopen(/Users/runner/bld/gradient-agreement-filtering_1735654061558/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.9/site-packages/torch/_C.cpython-39-darwin.so, 0x0002): Symbol not found: __ZN4absl12lts_2024072212log_internal10LogMessagelsIiLi0EEERS2_RKT_
  Referenced from: <ABD8BED3-9FF3-30AE-9F2C-FB6F306CF934> /Users/runner/bld/gradient-agreement-filtering_1735654061558/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/libprotobuf.28.2.0.dylib
  Expected in:     <E99B267F-7144-31DD-A5D4-F5B0B82894DA> /Users/runner/bld/gradient-agreement-filtering_1735654061558/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/libabsl_log_internal_message.2407.0.0.dylib

Is this really noarch?

@sarthakpati
Copy link
Contributor Author

That's what it seems like:

(venv_conda_recipes) sp@pc:/mnt/c/Users/sarth/Downloads$ ll gradient_agreement_filtering-0.1.3.tar.gz
-rwxrwxrwx 1 sp sp 7383 Jan  3 08:59 gradient_agreement_filtering-0.1.3.tar.gz*
(venv_conda_recipes) sp@pc:/mnt/c/Users/sarth/Downloads$ tar -xf gradient_agreement_filtering-0.1.3.tar.gz
(venv_conda_recipes) sp@pc:/mnt/c/Users/sarth/Downloads$ ll gradient_agreement_filtering-0.1.3
total 20
drwxrwxrwx 1 sp sp 4096 Dec 10 20:37 ./
drwxrwxrwx 1 sp sp 4096 Jan  3 09:00 ../
-rwxrwxrwx 1 sp sp 1066 Dec 10 20:37 LICENSE*
-rwxrwxrwx 1 sp sp 6559 Dec 10 20:37 PKG-INFO*
-rwxrwxrwx 1 sp sp 4982 Dec 10 20:37 README.md*
-rwxrwxrwx 1 sp sp  426 Dec 10 20:37 pyproject.toml*
-rwxrwxrwx 1 sp sp   38 Dec 10 20:37 setup.cfg*
drwxrwxrwx 1 sp sp 4096 Dec 10 20:37 src/
drwxrwxrwx 1 sp sp 4096 Dec 10 20:37 test/
(venv_conda_recipes) sp@pc:/mnt/c/Users/sarth/Downloads$ cat gradient_agreement_filtering-0.1.3/pyproject.toml
[project]
name = "gradient_agreement_filtering"
version = "0.1.3"
description = "Gradient Agreement Filtering (GAF) Package"
authors = [
  { name="Francois Chaubard", email="fchaubard@gmail.com" }
]
license = { file = "LICENSE" }
readme = "README.md"
requires-python = ">=3.7"
dependencies = [
  "torch",
  "torchvision",
  "numpy"
]

[tool.setuptools]
package-dir = {"" = "src"}
py-modules = ["gradient_agreement_filtering"]
(venv_conda_recipes) sp@pc:/mnt/c/Users/sarth/Downloads$ cat gradient_agreement_filtering-0.1.3/setup.cfg
[egg_info]
tag_build =
tag_date = 0

@ocefpaf
Copy link
Member

ocefpaf commented Jan 3, 2025

It may be a missing symbol in the dependencies. I just saw a similar failure elsewhere.

@sarthakpati
Copy link
Contributor Author

I assume you are talking about this?

@sarthakpati
Copy link
Contributor Author

sarthakpati commented Jan 3, 2025

I am seeing the same torch version getting installed for both these PRs (2.5.1). Perhaps there is an issue with that specific version + python 3.9? Anyway, I am trying with another version to confirm.

Otherwise, I have no idea why this would come up.

@sarthakpati
Copy link
Contributor Author

I don't understand why this error would come up after I have updated the version requirement for torch:

raise ValueError("Mixing meta.yaml and recipe.yaml recipes is not supported")

Any idea @ocefpaf?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gradient-agreement-filtering/meta.yaml) and found some lint.

Here's what I've got...

For recipes/gradient-agreement-filtering/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12602469872. Examine the logs at this URL for more detail.

@sarthakpati
Copy link
Contributor Author

@ocefpaf I have no idea how to solve that error. Shall I remove noarch and add osx to skip?

@sarthakpati
Copy link
Contributor Author

BTW, this is stemming from here: conda-forge/pytorch-cpu-feedstock#311

LMK what you think the best course of action would be.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gradient-agreement-filtering/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants