Add a noqt package and variants noqt5, noqt6 #25688

hmaarrfk · 2024-03-10T21:01:02Z

See conda-forge/opencv-feedstock#293 and more recent interest: #25669

@conda-forge/qt-main requests for comments and thoughts is greatly appreciated

@ocefpaf one of my concerns was about "maintainability" of this package. It seems that the only way to update such a package is through repodata patches. As such, I decided to create out of an abundance of caution a noqt4 package. Let me know what you think.

cc: @traversaro @jschueller

Checklist

conda-forge-webservices · 2024-03-10T21:01:14Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/noqt) and found some lint.

Here's what I've got...

For recipes/noqt:

The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/qt-main. Please ask them to comment on this PR if they are.

hmaarrfk · 2024-03-10T21:17:23Z

recipes/noqt/meta.yaml

+        # qt-main is essentially qt5
+        - qt-main <0.a0
+        # before the creation of qt-main, a megapackage called qt existed
+        - qt <0.a0


should this be loosened to qt <5.a0 to allow for qt4 to be installed? i feel like that will cause a whole set of other problems.

Exactly, hence why I think the distinction between noqt5 and noqt4 isn't worth it.

ocefpaf · 2024-04-16T15:58:25Z

@ocefpaf one of my concerns was about "maintainability" of this package. It seems that the only way to update such a package is through repodata patches. As such, I decided to create out of an abundance of caution a noqt4 package. Let me know what you think.

For some odd reason I missed this ping. I'm OK with it. I don't see any obvious downsides.

stale · 2024-09-25T16:49:53Z

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

github-actions · 2024-09-25T16:51:21Z

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

recipes/noqt/meta.yaml:
- lints:
  - The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/qt-main. Please ask them to comment on this PR if they are.

conda-forge-admin · 2024-10-12T14:30:41Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/noqt/meta.yaml) and found it was in an excellent condition.

hmaarrfk · 2024-10-12T15:06:59Z

I've reopened this because it seems like it may help at compilation to resolve environments.
conda-forge/freecad-feedstock#122

h-vetinari

Thanks for coming up with this! I think the idea is great, and it would be great to have for certain build scenarios! Some comments below.

recipes/noqt/meta.yaml

h-vetinari · 2024-10-13T03:02:24Z

recipes/noqt/meta.yaml

+    build:
+      noarch: generic
+    requirements:
+      run_constrained:
+        # qt4 only ever had a "mega qt" package called qt
+        - qt <0.a0|>=5.a0
+    test:
+      commands:
+        - echo "no tests for this package"


I would skip noqt4 completely. qt4 is so old (the last build was >5 years ago) that it's essentially uninstallable anyway.

With noqt5 requiring both qt <0.0a0 and qt-main <0.0a0, that already encompasses all remnants of qt4 that might exist.

ok. i removed noqt4.

h-vetinari · 2024-10-13T03:04:21Z

recipes/noqt/meta.yaml

+        # qt-main is essentially qt5
+        - qt-main <0.a0
+        # before the creation of qt-main, a megapackage called qt existed
+        - qt <0.a0


We need a minor version before the "a0". Also, I would only do qt-main <5.0a0, so we don't close the door that qt6-main eventually becomes qt-main. That the output got renamed was to enable co-installation; once qt5 fades away, we won't need that anymore. Not saying that's a good enough reason to then change it, but it might happen.

Suggested change

# qt-main is essentially qt5

- qt-main <0.a0

# before the creation of qt-main, a megapackage called qt existed

- qt <0.a0

# qt-main only exists as of 5.x

- qt-main <5.0a0

# before the creation of qt-main, a megapackage called qt existed

- qt <0.0a0

Thanks o hope i addressed the 2 points.

h-vetinari · 2024-10-13T03:04:40Z

recipes/noqt/meta.yaml

+      run_constrained:
+        # For qt6, we always had qt6-main
+        - qt6-main <0.a0


Suggested change

run_constrained:

# For qt6, we always had qt6-main

- qt6-main <0.a0

run_constrained:

# For qt6, we always had qt6-main

- qt6-main <0.0a0

h-vetinari · 2024-10-13T03:05:12Z

recipes/noqt/meta.yaml

+        # qt-main is essentially qt5
+        - qt-main <0.a0
+        # before the creation of qt-main, a megapackage called qt existed
+        - qt <0.a0


Exactly, hence why I think the distinction between noqt5 and noqt4 isn't worth it.

h-vetinari · 2024-10-13T03:11:01Z

one of my concerns was about "maintainability" of this package. It seems that the only way to update such a package is through repodata patches.

What do you mean here? Like if the structure of the qt packages changes, we need to modify the repodata? I think that's an acceptable price if we end up doing big changes (which would have to be well-justified in and of themselves anyway).

hmaarrfk · 2024-10-13T21:40:06Z

I mostly mean helping to reduce the scope of this.

For now, that means removing the noqt4 package.

h-vetinari · 2024-10-14T00:36:31Z

recipes/noqt/meta.yaml

        # qt-main only exists as of 5.x
-        - qt-main <0.0a0
+        - qt-main <5.0a0|>=6.0a0


I remember some discussion in mamba recently about these kind of "or" specifiers. Can we get confirmation that they're fully supported in mamba (@jjerphan @JohanMabille) & pixi (@wolfv @baszalmstra)?

The | operator is supported by mamba.

For instance see this test out of many more in the same file.

IIRC, the discussion were around another MatchSpec, namely openblas 0.2.18|0.2.18.*. for which the trailing *. segment is not properly supported.

Fully supported by rattler/py-rattler/pixi/rattler-build as well.

recipes/noqt/meta.yaml

h-vetinari

LGTM, thanks!

recipes/noqt/meta.yaml

h-vetinari · 2024-10-17T23:26:58Z

I think we're good to merge here?

hmaarrfk · 2024-10-18T00:37:28Z

yes, feel free to press merge, but i don't think it resolves your main concern. (more info on the original feedstock that brought us here)

@ocefpaf

See conda-forge/opencv-feedstock#293 and more recent interest: conda-forge#25669 @conda-forge/qt-main requests for comments and thoughts is greatly appreciated @ocefpaf one of my concerns was about "maintainability" of this package. It seems that the only way to update such a package is through repodata patches. As such, I decided to create out of an abundance of caution a noqt4 package. Let me know what you think.

Co-authored-by: h-vetinari <h.vetinari@gmx.com>

hmaarrfk · 2024-10-20T14:06:36Z

I think this can at least help CIs avoid a qt download. users can add "noqt" to help the solving from finding qt.

hmaarrfk changed the title ~~Add a noqt5 package and variants~~ Add a noqt package and variants noqt4, noqt5, noqt6 Mar 10, 2024

hmaarrfk commented Mar 10, 2024

View reviewed changes

This was referenced Mar 11, 2024

Add headless options conda-forge/opencv-feedstock#396

Merged

Packages that can target either Qt5, or Qt6, but not both at the same time conda-forge/qt-main-feedstock#208

Open

hmaarrfk mentioned this pull request Mar 29, 2024

CI is broken, Windows-WSL (and some other Linux) users need some extra systems packages flatironinstitute/CaImAn#1312

Closed

stale bot added the stale will be closed in 30 days label Sep 25, 2024

hmaarrfk closed this Sep 25, 2024

hmaarrfk mentioned this pull request Oct 11, 2024

Qt6, pcl 1.14.1, occt 7.8.1, vtk 9.3.1, boost 1.86, hdf5 1.14.4 conda-forge/freecad-feedstock#122

Closed

5 tasks

hmaarrfk reopened this Oct 12, 2024

stale bot removed the stale will be closed in 30 days label Oct 12, 2024

hmaarrfk force-pushed the noqt branch from f1bde43 to 2847766 Compare October 12, 2024 14:28

h-vetinari reviewed Oct 13, 2024

View reviewed changes

h-vetinari reviewed Oct 14, 2024

View reviewed changes

h-vetinari changed the title ~~Add a noqt package and variants noqt4, noqt5, noqt6~~ Add a noqt package and variants noqt5, noqt6 Oct 14, 2024

h-vetinari approved these changes Oct 15, 2024

View reviewed changes

recipes/noqt/meta.yaml Outdated Show resolved Hide resolved

hmaarrfk and others added 5 commits October 20, 2024 10:05

Update the url

bf2502e

Update recipes/noqt/meta.yaml

da010fd

Co-authored-by: h-vetinari <h.vetinari@gmx.com>

Update recipes/noqt/meta.yaml

c76b55d

Co-authored-by: h-vetinari <h.vetinari@gmx.com>

Add other suggestions

cc42bd3

hmaarrfk and others added 3 commits October 20, 2024 10:05

remove noqt4

2fc8bd4

Apply suggestions from code review

48c2953

Update recipes/noqt/meta.yaml

6855963

Co-authored-by: h-vetinari <h.vetinari@gmx.com>

hmaarrfk force-pushed the noqt branch from 23a2ac1 to 6855963 Compare October 20, 2024 14:05

hmaarrfk merged commit a1fa513 into conda-forge:main Oct 20, 2024
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a noqt package and variants noqt5, noqt6 #25688

Add a noqt package and variants noqt5, noqt6 #25688

hmaarrfk commented Mar 10, 2024

conda-forge-webservices bot commented Mar 10, 2024

hmaarrfk Mar 10, 2024

h-vetinari Oct 13, 2024

ocefpaf commented Apr 16, 2024

stale bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

conda-forge-admin commented Oct 12, 2024

hmaarrfk commented Oct 12, 2024

h-vetinari left a comment

h-vetinari Oct 13, 2024

hmaarrfk Oct 13, 2024

h-vetinari Oct 13, 2024 •

edited

Loading

hmaarrfk Oct 13, 2024

h-vetinari Oct 13, 2024

hmaarrfk Oct 13, 2024

h-vetinari Oct 13, 2024

h-vetinari commented Oct 13, 2024

hmaarrfk commented Oct 13, 2024

h-vetinari Oct 14, 2024

jjerphan Oct 14, 2024

wolfv Oct 15, 2024

h-vetinari left a comment

h-vetinari commented Oct 17, 2024

hmaarrfk commented Oct 18, 2024

hmaarrfk commented Oct 20, 2024

Add a noqt package and variants noqt5, noqt6 #25688

Add a noqt package and variants noqt5, noqt6 #25688

Conversation

hmaarrfk commented Mar 10, 2024

conda-forge-webservices bot commented Mar 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocefpaf commented Apr 16, 2024

stale bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

conda-forge-admin commented Oct 12, 2024

hmaarrfk commented Oct 12, 2024

h-vetinari left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

h-vetinari Oct 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

h-vetinari commented Oct 13, 2024

hmaarrfk commented Oct 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

h-vetinari left a comment

Choose a reason for hiding this comment

h-vetinari commented Oct 17, 2024

hmaarrfk commented Oct 18, 2024

hmaarrfk commented Oct 20, 2024

h-vetinari Oct 13, 2024 •

edited

Loading