Package Khronos OpenCL ICD loader for Windows #1763
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Surprisingly: Looks good from my end. Ready to review. |
|
This package is reasonably straightforward with the one caveat that they have cleverly decided to manufacture their own license. The license itself is probably not technically DFSG-free, but it does not impose any unreasonable restrictions on end users: https://github.com/KhronosGroup/OpenCL-ICD-Loader/blob/master/LICENSE.txt What can I do to help this get merged? Having this merged would (likely) allow me to have Windows builds of pyopencl. |
|
(bump) |
|
@conda-forge/core Could anyone take a look at this PR? It's ready to go as far as I can tell. |
|
|
||
| build: | ||
| number: 0 | ||
|
|
There was a problem hiding this comment.
The comment below and the extra space seems unnecessary, but feel free to keep it if you disagree as that does not prevent us from merging this.
There was a problem hiding this comment.
I'd rather keep the comment--and the empty line for visual separation, to help explain why this is Windows-only.
|
|
||
| requirements: | ||
| build: | ||
| - toolchain |
There was a problem hiding this comment.
This is unnecessary. At the end of the day the toolchain only changes, and in an irreproducible way since it is not versioned, the builds on OS X.
There was a problem hiding this comment.
Should be fine to drop as Windows only. toolchain is a no-op there.
That being said, I disagree with @ocefpaf on his statements w.r.t. the toolchain generally.
| about: | ||
| home: https://www.khronos.org/registry/cl/ | ||
| dev_url: https://github.com/KhronosGroup/OpenCL-ICD-Loader | ||
| license: Potentially non-free semi-copyleft dumpster fire |
There was a problem hiding this comment.
Commented on this above:
The license itself is probably not technically DFSG-free, but it does not impose any unreasonable restrictions on end users:
https://github.com/KhronosGroup/OpenCL-ICD-Loader/blob/master/LICENSE.txt
What's conda-forge's policy regarding weird (but not necessarily malicious) licenses?
There was a problem hiding this comment.
In theory all we need is permission to package and re-distribute binaries. But people usually stay away from non-conventional because we are not lawyers 😄
There was a problem hiding this comment.
Ok, makes sense. IMO, the license is a bit wacky, but it does not prevent packaging and binary redistribution. It also doesn't expose mere users to any risk, so I think this should be OK.
There was a problem hiding this comment.
We have packaged things with non-standard licenses. Though I completely understand the concern. From what I can tell this seems like a modified BSD 3-Clause license though IANAL.
Though maybe we should call it "The Khronos Group License" or something else. We can have this discussion in the feedstock though.
There was a problem hiding this comment.
The only lines that stood out to me were these.
If the binary is used as part of an OpenCL(TM) implementation, whether binary
is distributed together with or separately to that implementation, then
recipient must become an OpenCL Adopter and follow the published OpenCL
conformance process for that implementation, details at:
http://www.khronos.org/conformance/;
However, these seem to be obligations on the maintainer.
|
Thanks for reviewing this PR, @jakirkham and @ocefpaf! |
I did this just to see what would happen. Don't blame me.