-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require OS X 10.9/XCode 6.1 #1716
Conversation
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
LGTM should I wait for Travis? |
We should wait long enough to verify it is picking the image we expect. |
Thanks @jakirkham |
Great catch @jakirkham! Can't believe they didn't email us or something! |
Me too. 😞 |
Though are we sure this is doing the right thing? This line doesn't look like what I would expect. Any ideas on how to fix this? |
Weird, because if you look at the "View Config" tab, it says it has the right image. This might be a bug in Travis |
@@ -2,6 +2,7 @@ | |||
language: generic | |||
|
|||
os: osx | |||
osx_image: xcode6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham There is no 6.1 image! We would have to use beta-xcode6.1
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beat me to it by 5 seconds, @patricksnape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering about this, but it seems to have worked for other people. Will try adding a beta in a new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now with beta. 😉
xref: #1717
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also raised an upstream issue about erroring out builds where osx_image
refers to a non-existent image.
xref: travis-ci/travis-ci#6684
You mean you wish they published things like these? https://blog.travis-ci.com/2016-09-15-new-default-osx-image-coming/ |
Note in the first post they mention simplifying down to:
So we shouldn't rely on 6.1 as more than a stop gap. |
Well yes the blog posts are there but i don't frequently (ever) peruse the Travis blog. A banner on the site would be far more useful for such a breaking change. I can guarantee we won't be the only people to trip up over this. Removing 6.1 is just a pain for us because we wanted to support back to 10.9. |
So they communicated, but didn't do it in the way you would have liked? I'm confused, because the reason I subscribe to their blog (and twitter account) is precisely so I see things like this. |
Thanks for the links @dopplershift. We should discuss soon (maybe at a meeting) what we want to do about this problem long term. Short term we will need to get back to the image we had. |
Please see issue ( conda-forge/conda-forge.github.io#249 ) where I have tried to layout this issue. It is mainly informed by @dopplershift xrefs and a little more reading. Let's continue the discussion over there. |
@conda-forge/core, this is urgent!
This sets the base Travis CI image so it requires OS X 10.9/XCode 6.1 explicitly as the Travis CI default changed appears to have changed to OS X 10.11/XCode 7.3. Please see build, which appears to be the last build on
master
using OS X 10.9/XCode 6.1. Note that the next build and every subsequent build now appears to be using OS X 10.11/XCode 7.3 by default.Edit: Proposed similar change to
conda-smithy
in PR ( conda-forge/conda-smithy#325 ). We should merge that and release it after verifying this works and have merged it.xref: travis-ci/travis-ci#6522
xref: travis-ci/travis-ci#6677