Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require OS X 10.9/XCode 6.1 #1716

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Oct 5, 2016

@conda-forge/core, this is urgent!

This sets the base Travis CI image so it requires OS X 10.9/XCode 6.1 explicitly as the Travis CI default changed appears to have changed to OS X 10.11/XCode 7.3. Please see build, which appears to be the last build on master using OS X 10.9/XCode 6.1. Note that the next build and every subsequent build now appears to be using OS X 10.11/XCode 7.3 by default.

Edit: Proposed similar change to conda-smithy in PR ( conda-forge/conda-smithy#325 ). We should merge that and release it after verifying this works and have merged it.

xref: travis-ci/travis-ci#6522
xref: travis-ci/travis-ci#6677

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@scopatz
Copy link
Member

scopatz commented Oct 5, 2016

LGTM should I wait for Travis?

@jakirkham
Copy link
Member Author

We should wait long enough to verify it is picking the image we expect.

@scopatz scopatz merged commit 4e5eb02 into conda-forge:master Oct 5, 2016
@scopatz
Copy link
Member

scopatz commented Oct 5, 2016

Thanks @jakirkham

@patricksnape
Copy link
Contributor

patricksnape commented Oct 5, 2016

Great catch @jakirkham! Can't believe they didn't email us or something!

@jakirkham
Copy link
Member Author

Me too. 😞

@jakirkham
Copy link
Member Author

Though are we sure this is doing the right thing? This line doesn't look like what I would expect. Any ideas on how to fix this?

@scopatz
Copy link
Member

scopatz commented Oct 5, 2016

Weird, because if you look at the "View Config" tab, it says it has the right image. This might be a bug in Travis

@@ -2,6 +2,7 @@
language: generic

os: osx
osx_image: xcode6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham There is no 6.1 image! We would have to use beta-xcode6.1!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it by 5 seconds, @patricksnape.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering about this, but it seems to have worked for other people. Will try adding a beta in a new PR.

xref: travis-ci/travis-ci#6522 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with beta. 😉

xref: #1717

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also raised an upstream issue about erroring out builds where osx_image refers to a non-existent image.

xref: travis-ci/travis-ci#6684

@dopplershift
Copy link
Member

You mean you wish they published things like these?

https://blog.travis-ci.com/2016-09-15-new-default-osx-image-coming/
https://blog.travis-ci.com/2016-10-04-osx-73-default-image-live/

@dopplershift
Copy link
Member

Note in the first post they mention simplifying down to:

  • osx_image: xcode6.4 (with 10.10)
  • osx_image: xcode7.3 (with 10.11 and default)
  • osx_image: xcode8 (currently 10.11, but tentatively planned to be 10.12 for this release)

So we shouldn't rely on 6.1 as more than a stop gap.

@jakirkham jakirkham deleted the use_xcode_6.1_osx_10.9 branch October 5, 2016 18:58
@patricksnape
Copy link
Contributor

Well yes the blog posts are there but i don't frequently (ever) peruse the Travis blog. A banner on the site would be far more useful for such a breaking change. I can guarantee we won't be the only people to trip up over this.

Removing 6.1 is just a pain for us because we wanted to support back to 10.9.

@dopplershift
Copy link
Member

So they communicated, but didn't do it in the way you would have liked? I'm confused, because the reason I subscribe to their blog (and twitter account) is precisely so I see things like this.

@jakirkham
Copy link
Member Author

Thanks for the links @dopplershift.

We should discuss soon (maybe at a meeting) what we want to do about this problem long term. Short term we will need to get back to the image we had.

@jakirkham
Copy link
Member Author

Please see issue ( conda-forge/conda-forge.github.io#249 ) where I have tried to layout this issue. It is mainly informed by @dopplershift xrefs and a little more reading. Let's continue the discussion over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants