Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gym-ignition-models package #16573

Merged
merged 3 commits into from
Oct 19, 2021

Conversation

diegoferigo
Copy link
Contributor

@diegoferigo diegoferigo commented Oct 18, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gym-ignition-models) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/gym-ignition-models:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@diegoferigo diegoferigo force-pushed the diegoferigo/gym-ignition-models branch from 56426a2 to 7c0042b Compare October 18, 2021 13:12
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gym-ignition-models) and found it was in an excellent condition.

@diegoferigo diegoferigo force-pushed the diegoferigo/gym-ignition-models branch from 7c0042b to 793942f Compare October 18, 2021 14:26
@diegoferigo
Copy link
Contributor Author

@conda-forge-admin, please ping team

This recipe is ready for review.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@wolfv wolfv merged commit a520c19 into conda-forge:main Oct 19, 2021
@diegoferigo diegoferigo deleted the diegoferigo/gym-ignition-models branch October 19, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants