-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clangdev recipe #1481
Add clangdev recipe #1481
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/clangdev:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/clangdev:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This requires https://github.com/numba/llvmlite/tree/master/conda-recipes/llvmdev
|
-DBUILD_SHARED_LIBS=ON \ | ||
-DCMAKE_INSTALL_PREFIX=$PREFIX \ | ||
.. | ||
cmake --build . -- -j 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't trust the 8
here as we never know how many cores the CIs will provide. If you are feeling brave you can try the CPU_COUNT
env var which should use the last known number of cores for each CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, although oversubscribing is not usually an issue in my experience--i.e. 8 is fine even for single-core, assuming there's sufficient RAM.
Made the same change in llvmdev
, #1482.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@jakirkham The Windows build here: https://ci.appveyor.com/project/conda-forge/staged-recipes/build/1.0.7739/job/ciaib6t66ims0kl9#L268 seems to say that |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hum, no build is created on AppVeyor--why? |
Seems like some of the python scripts in llvm don't support python 3. There are also errors in the circleCI build for the same issue while compiling to |
Yeah, it's the same for |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/core Something that I don't understand is happening in my Circle/LInux build. I get what seems like a perfectly successful Python 3.5 build, and then another build starts, perhaps for Python 3.6, which is missing CMake...? I'm not sure what to make of that, and I'd appreciate any hints you can provide. |
It looks like Python 3.6 leaked here. I fixed the label a not long ago and hopefully that should fix it. I restarted the CI. Fingers crossed. |
Thanks! |
Hum, that died again, complaining that it can't find |
It seems that it did find CMake 3.4.3 or higher is required. You are running version 3.2.2 The weird thing is that On
Did you try that configuration in the docker image? |
Thanks for helping!
What configuration? How? |
|
||
# "compiling .pyc files" fails without this: | ||
- python # [not win] | ||
- python {{ environ['PY_VER'] + '*' }} # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let the skip section above that care of this for you. use only python
here and remove the pre-selectors. you can also add vc 14 # [win]
to ensure the right vc
though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed combining with python
should be fine.
I meant the failing item of the matrix there. It seems to be
We do not have docs on the use of the docker image yet but here is the gist of it: docker pull condaforge/linux-anvil # download the image
docker run -it --rm -v $(pwd):/home/ condaforge/linux-anvil /bin/sh # "enter" the image for a staged build
cd home # the directory we mounted in the image (you need to be in the recipe directory in the command above)
export CONDA_PY=35 # the python version that is failing in your recipe
conda build . |
cc @mattwala (Just in case being sick this afternoon is not enough to keep you occupied.) |
This reverts commit 88b0c70.
Now that the XCode image has been bumped. Could we please merge/rebase this with |
Done. |
Looks like all the tests passed. |
Thanks @inducer. Let's get it into a feedstock. 😀 |
No description provided.