Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clangdev recipe #1481

Merged
merged 38 commits into from
Jan 19, 2017
Merged

Add clangdev recipe #1481

merged 38 commits into from
Jan 19, 2017

Conversation

inducer
Copy link
Contributor

@inducer inducer commented Sep 4, 2016

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/clangdev) and found some lint.

Here's what I've got...

For recipes/clangdev:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/clangdev) and found some lint.

Here's what I've got...

For recipes/clangdev:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clangdev) and found it was in an excellent condition.

@inducer
Copy link
Contributor Author

inducer commented Sep 5, 2016

This requires llvmdev, but that's in the numba channel. I could of course copy this:

https://github.com/numba/llvmlite/tree/master/conda-recipes/llvmdev

But that seems like the wrong way to go about it. You know what: why not.

@inducer inducer mentioned this pull request Sep 5, 2016
@inducer
Copy link
Contributor Author

inducer commented Sep 5, 2016

FWIW, with #1481, #1479, #1482, I'm building towards a recipe for pocl, and based on that pyopencl.

-DBUILD_SHARED_LIBS=ON \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
..
cmake --build . -- -j 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't trust the 8 here as we never know how many cores the CIs will provide. If you are feeling brave you can try the CPU_COUNT env var which should use the last known number of cores for each CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, although oversubscribing is not usually an issue in my experience--i.e. 8 is fine even for single-core, assuming there's sufficient RAM.

Made the same change in llvmdev, #1482.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clangdev38) and found it was in an excellent condition.

@inducer inducer changed the title Add clangdev recipe Add clangdev38 recipe Sep 5, 2016
@inducer
Copy link
Contributor Author

inducer commented Sep 5, 2016

FWIW, this is stalled until #1482 is merged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clangdev) and found it was in an excellent condition.

@inducer inducer changed the title Add clangdev38 recipe Add clangdev recipe [WIP] Oct 8, 2016
@inducer inducer closed this Oct 8, 2016
@inducer inducer reopened this Oct 8, 2016
@inducer
Copy link
Contributor Author

inducer commented Oct 9, 2016

@jakirkham The Windows build here:

https://ci.appveyor.com/project/conda-forge/staged-recipes/build/1.0.7739/job/ciaib6t66ims0kl9#L268

seems to say that llvmdev conflicts with toolchain on account of the vc14 feature. I'm currently working around that by depending on toolchain # [not win], since toolchain appears to be a no-op there. Is that the correct fix?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@inducer
Copy link
Contributor Author

inducer commented Nov 5, 2016

Hum, no build is created on AppVeyor--why?

@inducer inducer closed this Nov 5, 2016
@inducer inducer reopened this Nov 5, 2016
@yesimon
Copy link
Contributor

yesimon commented Nov 5, 2016

Seems like some of the python scripts in llvm don't support python 3. There are also errors in the circleCI build for the same issue while compiling to .pyc. I think these are support scripts like clang-format.py that don't affect the basic functionality of clang.

@inducer
Copy link
Contributor Author

inducer commented Nov 5, 2016

Seems like some of the python scripts in llvm don't support python 3.

Yeah, it's the same for llvmdev. But, as you say, there doesn't seem to be an overall adverse effect on the build.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clangdev) and found it was in an excellent condition.

@inducer
Copy link
Contributor Author

inducer commented Dec 5, 2016

@conda-forge/core Something that I don't understand is happening in my Circle/LInux build. I get what seems like a perfectly successful Python 3.5 build, and then another build starts, perhaps for Python 3.6, which is missing CMake...? I'm not sure what to make of that, and I'd appreciate any hints you can provide.

@ocefpaf
Copy link
Member

ocefpaf commented Dec 5, 2016

It looks like Python 3.6 leaked here. I fixed the label a not long ago and hopefully that should fix it. I restarted the CI. Fingers crossed.

@inducer
Copy link
Contributor Author

inducer commented Dec 5, 2016

Thanks!

@inducer
Copy link
Contributor Author

inducer commented Dec 6, 2016

Hum, that died again, complaining that it can't find cmake. But cmake is in the dependencies, and it finds it on the first build. No Python 3.6 this time though. Any clues?

@ocefpaf
Copy link
Member

ocefpaf commented Dec 6, 2016

It seems that it did find cmake but not the expected version on Travis-CI:

 CMake 3.4.3 or higher is required.  You are running version 3.2.2

The weird thing is that cmake 3.6.2 is installed 😕

On CircleCI the same cmake is installed but a different error is issued:

/staged-recipes/build_artefacts/work/cfe-3.9.0.src/conda_build.sh: line 6: cmake: command not found

Did you try that configuration in the docker image?

@inducer
Copy link
Contributor Author

inducer commented Dec 7, 2016

Thanks for helping!

Did you try that configuration in the docker image?

What configuration? How?


# "compiling .pyc files" fails without this:
- python # [not win]
- python {{ environ['PY_VER'] + '*' }} # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the skip section above that care of this for you. use only python here and remove the pre-selectors. you can also add vc 14 # [win] to ensure the right vc though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed combining with python should be fine.

@ocefpaf
Copy link
Member

ocefpaf commented Dec 7, 2016

What configuration?

I meant the failing item of the matrix there. It seems to be CONDA_PY=35.

How?

We do not have docs on the use of the docker image yet but here is the gist of it:

docker pull condaforge/linux-anvil  # download the image
docker run -it --rm -v $(pwd):/home/ condaforge/linux-anvil /bin/sh  # "enter" the image for a staged build
cd home  # the directory we mounted in the image (you need to be in the recipe directory in the command above)
export CONDA_PY=35  # the python version that is failing in your recipe
conda build .

@inducer
Copy link
Contributor Author

inducer commented Dec 7, 2016

cc @mattwala (Just in case being sick this afternoon is not enough to keep you occupied.)

@jakirkham
Copy link
Member

Now that the XCode image has been bumped. Could we please merge/rebase this with master?

@inducer
Copy link
Contributor Author

inducer commented Jan 18, 2017

Done.

@inducer
Copy link
Contributor Author

inducer commented Jan 19, 2017

Looks like all the tests passed.

@jakirkham jakirkham merged commit f27a0a4 into conda-forge:master Jan 19, 2017
@jakirkham
Copy link
Member

Thanks @inducer. Let's get it into a feedstock. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants