Fix sed syntax and macOS bundle names with spaces #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$(dirname $0) allows bundle portablility (user renames bundle), but shell script requires "$(dirname "$0")" (yes, 2 sets of double quotes) if there is a space in the path. Unfortunately, menuisnt tries to be clever and quote the command, but does so incorrectly. $(dirname $0)/python -> "$(dirname $0)/python" $(dirname \"$0\")/python -> '$(dirname "$0")/python' \"$(dirname \"$0\")/python\" -> '"$(dirname "$0")/python"' The workaround is to use the precommand directive. Here menuinst does not try to clever quote and we can pushd to the directory.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
mrclary
added a commit
to mrclary/spyder
that referenced
this pull request
Jan 19, 2024
mrclary
added a commit
to mrclary/spyder
that referenced
this pull request
Jan 19, 2024
mrclary
added a commit
to mrclary/spyder
that referenced
this pull request
Jan 19, 2024
|
@mrclary, is this ready to be merged? |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Yet another fix: