-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for numpy 2.0 #274
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/scipy-feedstock/actions/runs/8761682437. |
linux_64_numpy1.22python3.9.____73_pypypython_implpypy: | ||
CONFIG: linux_64_numpy1.22python3.9.____73_pypypython_implpypy | ||
UPLOAD_PACKAGES: 'True' | ||
DOCKER_IMAGE: quay.io/condaforge/linux-anvil-cos7-x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be dropping the pypy (or py312) builds for 1.x. AFAICT this happens because the migrator for those can only add one key, not two (after the duplication here). More details in conda-forge/conda-forge-pinning-feedstock#5790.
97198b9
to
1c2ba40
Compare
@conda-forge/scipy, this is looking alright for everything except PyPy, which fails in three different ways on 3 different platforms - a hang on linux, missing
Note our PyPy builds are also broken on |
Makes sense, it would be nice to have a tracking issue to point to, so if there some interest in picking up PyPy support they have something to start from. |
Do you mean on the feedstock or in upstream scipy? Also, I just realised that this is going to play havoc with the migration for any SciPy-dependent feedsfock. Perhaps we should keep PyPy building against 1.x for now (not just for SciPy but in the migrator)? |
Maybe it is time to drop PyPy from future migrations. Packages that have been built should continue to work, so current users would not be suddenly cut off, and maintainers would not have to deal with the extra headache. I don't see a PyPy3.10 migration happening, and 3.9 is being dropped in the scientific python ecosystem. |
Those two things are equivalent in this context. Thanks for confirming. |
.ci_support/win_64_numpy2.0python3.10.____cpythonpython_implpypy.yaml
Outdated
Show resolved
Hide resolved
…04dba97.d20240503, and conda-forge-pinning 2024.05.02.11.25.06
This is for testing the migrator; also would need conda-forge/numpy-feedstock#313