Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for numpy 2.0 #274

Merged
merged 12 commits into from
May 4, 2024
Merged

Rebuild for numpy 2.0 #274

merged 12 commits into from
May 4, 2024

Conversation

h-vetinari
Copy link
Member

This is for testing the migrator; also would need conda-forge/numpy-feedstock#313

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/scipy-feedstock/actions/runs/8761682437.

Comment on lines 15 to 18
linux_64_numpy1.22python3.9.____73_pypypython_implpypy:
CONFIG: linux_64_numpy1.22python3.9.____73_pypypython_implpypy
UPLOAD_PACKAGES: 'True'
DOCKER_IMAGE: quay.io/condaforge/linux-anvil-cos7-x86_64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be dropping the pypy (or py312) builds for 1.x. AFAICT this happens because the migrator for those can only add one key, not two (after the duplication here). More details in conda-forge/conda-forge-pinning-feedstock#5790.

@h-vetinari h-vetinari changed the title WIP: Build against numpy 2.0 Rebuild for numpy 2.0 May 1, 2024
@h-vetinari h-vetinari marked this pull request as ready for review May 2, 2024 01:35
@h-vetinari
Copy link
Member Author

@conda-forge/scipy, this is looking alright for everything except PyPy, which fails in three different ways on 3 different platforms - a hang on linux, missing __ror__ on osx (see scipy/scipy#20472) and crashes on windows with

+++++++++++++++++++++++++++++++++++ Timeout +++++++++++++++++++++++++++++++++++
 WARNING: Maximum dimension of Krylov subspace exceeded prior to convergence. Try increasing KMAX.

Note our PyPy builds are also broken on main, so this is not specifically numpy 2.0 related. I'm tending towards dropping PyPy here for now. CC @mattip

@mattip
Copy link
Contributor

mattip commented May 2, 2024

I'm tending towards dropping PyPy here for now

Makes sense, it would be nice to have a tracking issue to point to, so if there some interest in picking up PyPy support they have something to start from.

@h-vetinari
Copy link
Member Author

it would be nice to have a tracking issue to point to

Do you mean on the feedstock or in upstream scipy?

Also, I just realised that this is going to play havoc with the migration for any SciPy-dependent feedsfock. Perhaps we should keep PyPy building against 1.x for now (not just for SciPy but in the migrator)?

@mattip
Copy link
Contributor

mattip commented May 3, 2024

Perhaps we should keep PyPy building against 1.x

Maybe it is time to drop PyPy from future migrations. Packages that have been built should continue to work, so current users would not be suddenly cut off, and maintainers would not have to deal with the extra headache. I don't see a PyPy3.10 migration happening, and 3.9 is being dropped in the scientific python ecosystem.

@h-vetinari
Copy link
Member Author

Perhaps we should keep PyPy building against 1.x

Maybe it is time to drop PyPy from future migrations.

Those two things are equivalent in this context. Thanks for confirming.

@h-vetinari h-vetinari merged commit 65fad17 into conda-forge:main May 4, 2024
1 of 26 checks passed
@h-vetinari h-vetinari deleted the numpy2 branch May 4, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants