-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Python version to 3.10 and add gazebo
dependencies
#8
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Can we also add the gazebo dependencies in this PR? |
gazebo
dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work! Thanks @flferretti.
@traversaro A curiosity, considering the way the Gazebo Sim suite is packaged distributed for side-to-side installation, is there any way to specify different combinations of packages? For example, in this case, both gz-tools2 libsdformat13
and gz-tools2 libsdformat14
would work.
@flferretti by chance have you tried to also run |
…nda-forge-pinning 2024.05.18.00.22.24
This is one downside of having a package for each major version. You can't specify that both |
Can we specify something like this |
Oh cool, I had no idea. To be honest I am a bit afraid of this, metadata will be processed by several codebases (conda, mamba and pixi basically all use different codebases for this) so I am not 100% sure this will produce the same result. |
13ed5aa
to
20b1198
Compare
Okay thanks! So I guess it's safer to just keep |
|
20b1198
to
9223264
Compare
Done in 6581ece |
If you do not install any test as part of the package, probably you need either to pass the tests as test files (better), or run the tests as part of the build step. |
If it works, it's a clever workaround. In any case, supporting multiple versions is not blocking. The sdformat package doesn't have a lot of dependencies, if old versions keep being rebuilt in case of migrations and can be installed side-by-side with new versions (therefore not interfering with the solver in case new versions are required in an environment), I guess we're pretty robust also with only the minimum requirement that is |
9223264
to
6581ece
Compare
Since the workaround does not work in the For what regards the tests, I'm getting an error on ImportError while importing test module '$SRC_DIR/tests/test_urdf_exporter.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/python.py:487: in importtestmodule
mod = import_path(
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/pathlib.py:591: in import_path
importlib.import_module(module_name)
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/importlib/__init__.py:90: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1387: in _gcd_import
???
<frozen importlib._bootstrap>:1360: in _find_and_load
???
<frozen importlib._bootstrap>:1331: in _find_and_load_unlocked
???
<frozen importlib._bootstrap>:935: in _load_unlocked
???
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:178: in exec_module
exec(co, module.__dict__)
tests/test_urdf_exporter.py:1: in <module>
import idyntree.bindings as idt
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/idyntree/__init__.py:1: in <module>
from . import swig
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/idyntree/swig.py:10: in <module>
from . import _iDynTree
E ImportError: libGL.so.1: cannot open shared object file: No such file or directory C.C. @traversaro |
Probably solved by https://conda-forge.org/docs/maintainer/maintainer_faq/#how-do-i-fix-the-libglso1-import-error |
Yes, you also need to re-render probably. |
@conda-forge-admin, please rerender |
It didn't work, I'm checking again to see if I'm missing something |
Probably some other packages are missing, check: https://github.com/conda-forge/idyntree-feedstock/blob/main/recipe/yum_requirements.txt |
…nda-forge-pinning 2024.05.20.05.45.14
037853f
to
edc0912
Compare
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/rod-feedstock/actions/runs/9157803404. |
Thanks Diego! Yet for some reason it looks like it still doesn't work |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/rod-feedstock/actions/runs/9158205457. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.05.20.05.45.14
I just noticed the extension, sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, LGTM as soon as CI turns green
I have no idea why |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)