Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling CUDA CUPTI on Windows #319

Closed
jakirkham opened this issue Jan 15, 2025 · 6 comments · Fixed by #328
Closed

Enabling CUDA CUPTI on Windows #319

jakirkham opened this issue Jan 15, 2025 · 6 comments · Fixed by #328

Comments

@jakirkham
Copy link
Member

Currently CUPTI is only used on Linux:

- cuda-cupti-dev # [linux]

However there are Windows packages for CUPTI

Would be interested to know if there were issues encountered during Windows bringup that need to be addressed

As it would be great if we could supply CUPTI enabled builds to Windows users

@h-vetinari
Copy link
Member

Would be interested to know if there were issues encountered during Windows bringup that need to be addressed

This combination was never tried. When merging the two separate efforts in #316, I didn't combine them (resp. disabled the equivalent changes from #305 for windows).

Happy to try to enable it in further builds going forward.

CC @mgorny

This was referenced Jan 16, 2025
@jakirkham
Copy link
Member Author

Ah ok. That makes sense. Thanks Axel! 🙏

@h-vetinari
Copy link
Member

@mgorny @Tobias-Fischer
Could I tempt either of you to try a PR that tackles this (+ #320 & #321)?

@Tobias-Fischer
Copy link
Contributor

@mgorny @Tobias-Fischer Could I tempt either of you to try a PR that tackles this (+ #320 & #321)?

Not me, sorry :)

@mgorny
Copy link
Contributor

mgorny commented Jan 19, 2025

Well, I can try making a PR but it'd rely on the CI testing it.

@h-vetinari
Copy link
Member

Well, I can try making a PR but it'd rely on the CI testing it.

That's completely fine. Just skip non-windows CI while we're debugging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants