Update pytest-cov to 2.4.0

[nicoddemus]

No description provided.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[dopplershift]

Can you re-render the feedstock with conda-smithy 1.3.3 and push those changes to your master branch? That should fix the build problems.

[nicoddemus]

Just did it! 😄

[dopplershift]

Thanks.

Well that's a weird error message for CircleCI. @conda-forge/core any ideas?

[nicoddemus]

Yeah, the checkout_merge_commit.sh script seems to be in place... strange.

[jakirkham]

That's an odd one. Going to restart and hope it was some transient CircleCI problem.

[jakirkham]

Weird. Could you please try doing chmod +x on that script and adding/committing?

[nicoddemus]

No change for me:

vagrant@thdengops-ubuntu-14:/vagrant/pytest-cov-feedstock$ chmod a+x ci_support/checkout_merge_commit.sh
vagrant@thdengops-ubuntu-14:/vagrant/pytest-cov-feedstock$ git st
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working directory clean

I wonder if the reason is that I'm on a vagrant box?

[nicoddemus]

Goddamit, I think that's it, I cloned the recipe on a shared folder with Windows!

[jakirkham]

Was wondering if Windows was in play. Do you mind filing an issue over at conda-smithy? We have been relying on executable permissions, which are not a sensible thing for us to rely on with Windows. We should start prefixing things like this with bash which should be an easy fix. Sorry for the hassle.

[jakirkham]

Should add I pushed the permission fixed file to your branch and it seems to be behaving correctly now FWICT.

[nicoddemus]

Should add I pushed the permission fixed file to your branch and it seems to be behaving correctly now FWICT.

Perfect, many thanks! I reported conda-forge/conda-smithy#330 as you asked. 😁

[jakirkham]

Awesome. Thanks.

[dopplershift]

Thanks! @nicoddemus if you're doing a lot of stuff in the pytest space, feel free to submit a PR adding yourself as a maintainer in the recipe here.

[nicoddemus]

if you're doing a lot of stuff in the pytest space, feel free to submit a PR adding yourself as a maintainer in the recipe here.

Thanks, I would like that yes. But I wonder if adding a user to the maintainers list of the recipe has any impact after the feedstock repository has been created. Perhaps @jakirkham or @ocefpaf know the answer?

[dopplershift]

The PR is the prescribed way to update maintainership. There's a script/service running somewhere that updates permissions after merging a PR. Part of the magic that @conda-forge/core has put together. 😁

[nicoddemus]

Wow that's cool. 😁

[jakirkham]

Correct, we run a cron job (currently a CI build on the web page repo) at least once daily (barring service outages and the like) that will transfer permissions to anyone recently added as a recipe maintainer. It also does other things like updates the feedstocks listing on the webpage and the feedstocks repo. Long term we are planning to move this to an asynchronous webservice that updates after there is a push to any feedstock.