-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcmdi_metrics v2.3 #6
pcmdi_metrics v2.3 #6
Conversation
…nda-forge-pinning 2022.06.08.23.30.54
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@lee1043 We need to check out this error in the linux testing: Based on some research (e.g. https://www.reddit.com/r/learnpython/comments/u3dibm/i_updated_all_my_python_modules_using_pip_and_now/), it looks like the "Mapping" library was moved to collections.abc in Python 3.3. I'm not sure why we haven't seen this error before. I am wondering if we need to update all the Mapping library calls in the PMP, or if it would work to pin an older Python version for this release (if you need it asap). |
@lee1043 Did some testing on my command line. I get the same error with the PMP 2.2.2 from conda-forge if I use the default Python version 3.10.4. Tested by creating a new environment and running "mean_climate_driver.py --help", which showed the ImportError. If I create a new environment and force the Python version to be 3.7, this command works. It looks like the old collections library alias is available up through version 3.7 (reference). If you need this release ASAP, we could pin Py>=3.6 and <3.8. Otherwise, it looks like we do need to eventually fix all the collections library calls to work with newer versions of Python. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comments
@acordonez thank you for the investigation. I see below message when I manually import Mapping from collections in python 3.9.7. It is saying it will stop working from python 3.10, which I think it is why we see the above error now.
It looks like the Correction: Found |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by source code inspection but not in the meta.yaml:
Packages found in the meta.yaml but not found by source code inspection:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2465676567, please use this URL for debugging.