Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try only documented requirements #22

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Try only documented requirements #22

merged 2 commits into from
Jun 29, 2024

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Jun 21, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

At least according to https://xiph.org/theora/ which links to the 1.1.1 source:

Both of implementations depend on the following libraries...

  • libogg-1.3.5
  • libvorbis-1.3.7
  • libSDL 1.2 or later for the playback example

So it doesn't seem like zlib or libpng dependencies should be needed to be specified. But this is a bit of a shot in the dark from my end. Hopefully the CIs will tell us. 🤷

Closes #21

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@larsoner
Copy link
Contributor Author

@conda-forge-admin, please rerender

@larsoner
Copy link
Contributor Author

Well it at least built successfully. Thoughts on this one @bgruening @dschreij ?

@hoechenberger
Copy link
Member

Friendly ping @bgruening @dschreij 🙂

@traversaro
Copy link

traversaro commented Jun 29, 2024

To give a bit more of motivation of this PR, libpng and zlib are indeed dependencies of libtheora, but only if the debug option OC_DUMP_IMAGES is enabled, see https://gitlab.xiph.org/xiph/theora/-/commit/d0c140ab9844a3074983fd3acd252b9bf5693ba0 . In existing builds, this option is not enabled, see https://gitlab.xiph.org/xiph/theora/-/blob/v1.1.1/lib/internal.h#L440-445 and inspection of existing builds (libtheora 1.1.1 h7f98852_1005 conda-forge):

(libtheora) traversaro@IITBMP014LW012:~/miniforge3/envs/libtheora/lib$ readelf -s libtheora.so | grep oc_state_loop
   182: 0000000000017f20  1541 FUNC    LOCAL  DEFAULT   12 oc_state_loop_fi[...]
   219: 0000000000016580   707 FUNC    LOCAL  DEFAULT   12 oc_state_loop_fi[...]
   254: 0000000000016850     3 FUNC    LOCAL  DEFAULT   12 oc_state_loop_fi[...]
   351: 0000000000014240   476 FUNC    LOCAL  DEFAULT   12 oc_state_loop_fi[...]
(libtheora) traversaro@IITBMP014LW012:~/miniforge3/envs/libtheora/lib$ readelf -s libtheora.so | grep oc_frag_copy
   185: 000000000000b930    15 FUNC    LOCAL  DEFAULT   12 oc_frag_copy
   216: 000000000000b940    88 FUNC    LOCAL  DEFAULT   12 oc_frag_copy_c
   241: 00000000000172a0    76 FUNC    LOCAL  DEFAULT   12 oc_frag_copy_mmx
(libtheora) traversaro@IITBMP014LW012:~/miniforge3/envs/libtheora/lib$ readelf -s libtheora.so | grep oc_state_dump
(libtheora) traversaro@IITBMP014LW012:~/miniforge3/envs/libtheora/lib$

@traversaro
Copy link

@conda-forge/core The PR is blocking libopencv 4.10 migration (see conda-forge/bipedal-locomotion-framework-feedstock#69) and per https://conda-forge.org/docs/maintainer/maintainer_faq/#a-feedstock-has-been-abandoned-and-i-would-like-to-take-over-maintenance the period of ~1 week without any maintainer response have passed. Furthermore, the last PR merged by a mantainer (as opposed to a core member) dates back to 2020, see #11 . Given that, it would be great to merge this PR to unblock libopencv migration and other zlib==1.3 related conflicts, and if a new maintainer is necessary I am happy to volunteer (see #24)

@ocefpaf ocefpaf merged commit 9180d3e into conda-forge:main Jun 29, 2024
8 checks passed
@larsoner larsoner deleted the pin branch June 29, 2024 13:28
@traversaro
Copy link

Thanks @ocefpaf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Pinning to zlib 1.2 is preventing future compat
4 participants