libprotobuf v5.26.0 #213
libprotobuf v5.26.0 #213
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Major version bump for C++ / Python, see https://protobuf.dev/news/ resp. protocolbuffers/protobuf@16afb4d
|
I get some failures on |
|
Now fixed and ready for review! |
There was a problem hiding this comment.
Thank you, @xhochy and @h-vetinari.
I just have one comment.
| # pkg-config metadata sets yet another version format, not using the major version | ||
| # but adding the rc number as a patch version, or 0 for regular releases |
There was a problem hiding this comment.
Is there some documentation about it somewhere?
There was a problem hiding this comment.
No idea TBH, would need some digging upstream; I just observed it while building the release candidates and put 2+2 together 😅
There was a problem hiding this comment.
I find this behavior of pkg-config dangerous. 👀
There was a problem hiding this comment.
I'm pretty sure it's the way protobuf has set up their metadata; in any case, we're doing exact matches on the versions (according to the pkg-config metadata) in the testing here, so I'm not too worried.
Currently on rc3; bunch of breaking changes causing major version bump see https://protobuf.dev/news & protocolbuffers/protobuf@16afb4d. The Python breaking changes look painful, but that's a question for the other feedstock...
Based on #208, will be rebased once that's in.