Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interaction with external gtest #170

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Fix interaction with external gtest #170

merged 3 commits into from
Aug 11, 2023

Conversation

h-vetinari
Copy link
Member

#168 was green before gtest 1.14 came out, which happened between the CI there and the final merge. 😑

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy
Copy link
Member

xhochy commented Aug 10, 2023

We need to better pin gtest in libabseil-tests. I will add run_exports to gtest and add a repodata patch to at least the last two libabseil-test versions.

@xhochy
Copy link
Member

xhochy commented Aug 10, 2023

See conda-forge/gtest-feedstock#71

@h-vetinari
Copy link
Member Author

We need to better pin gtest in libabseil-tests.

Ah, I had forgotten the abseil-side here. Thanks for rootcausing this!

@h-vetinari h-vetinari mentioned this pull request Aug 11, 2023
Merged
2 tasks
@h-vetinari h-vetinari merged commit 07a600d into conda-forge:main Aug 11, 2023
@h-vetinari h-vetinari deleted the fix branch August 11, 2023 03:28
@h-vetinari h-vetinari mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift Awaiting requested review from dopplershift dopplershift is a code owner

@hajapy hajapy Awaiting requested review from hajapy hajapy is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@wesm wesm Awaiting requested review from wesm wesm is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

@xylar xylar Awaiting requested review from xylar xylar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-vetinari @xhochy