-
-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
libprotobuf v25.1
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
From c54edc4ac169b2196d91ff6f6728cbefe5ae61c2 Mon Sep 17 00:00:00 2001 | ||
From: Isuru Fernando <isuruf@gmail.com> | ||
Date: Fri, 19 Jan 2024 19:14:50 -0600 | ||
Subject: [PATCH] Fix getting env variables on windows | ||
|
||
--- | ||
src/google/protobuf/compiler/mock_code_generator.cc | 8 +++++++- | ||
1 file changed, 7 insertions(+), 1 deletion(-) | ||
|
||
diff --git a/src/google/protobuf/compiler/mock_code_generator.cc b/src/google/protobuf/compiler/mock_code_generator.cc | ||
index d7057a1e6..8b6742687 100644 | ||
--- a/src/google/protobuf/compiler/mock_code_generator.cc | ||
+++ b/src/google/protobuf/compiler/mock_code_generator.cc | ||
@@ -73,7 +73,13 @@ static constexpr absl::string_view kSecondInsertionPoint = | ||
" # @@protoc_insertion_point(second_mock_insertion_point) is here\n"; | ||
|
||
MockCodeGenerator::MockCodeGenerator(absl::string_view name) : name_(name) { | ||
- absl::string_view key = getenv("TEST_CASE"); | ||
+ char* c_key = getenv("TEST_CASE"); | ||
+ if (c_key == NULL) { | ||
+ // In Windows, setting 'TEST_CASE=' is equivalent to unsetting | ||
+ // and therefore c_key can be NULL | ||
+ return; | ||
+ } | ||
+ absl::string_view key(c_key); | ||
if (key == "no_editions") { | ||
suppressed_features_ |= CodeGenerator::FEATURE_SUPPORTS_EDITIONS; | ||
} else if (key == "invalid_features") { | ||
-- | ||
2.42.0 | ||
|