Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress CUDA binary code #22

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Dec 11, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf requested review from carterbox and a team as code owners December 11, 2024 01:03
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 11, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12345421318. Examine the logs at this URL for more detail.

@jakirkham
Copy link
Member

Did you measure the difference between the two approaches? Would be interested to know how they compare

@isuruf
Copy link
Member Author

isuruf commented Dec 11, 2024

2GB -> 620 MB

@carterbox
Copy link
Member

This is unexpected to me since compression is enabled by default, but I guess compression has overhead for small files.

https://docs.nvidia.com/cuda/nvfatbin/index.html#supported-options

@carterbox
Copy link
Member

@conda-forge-admin, please rerender

@carterbox
Copy link
Member

I forgot the bot doesn't have permission to build on the CI.

@carterbox carterbox force-pushed the compress-cuda-binary-code branch from 368cf7d to f06510e Compare December 11, 2024 22:16
@carterbox carterbox merged commit 32d3817 into conda-forge:main Dec 16, 2024
12 checks passed
@carterbox
Copy link
Member

Thanks, @isuruf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants