-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transitioning to the conf.d enabling approach #111
Comments
👍 |
I propose that we start the transition by deleting the unlink scripts with the next version of JupyterLab, and wait at least 6 months (i.e., a year after notebook 5.3 was released) for people to move to these newer versions of JupyterLab and the notebook before deleting the link scripts. |
Sounds good to me |
Let's try to remember to delete the unlink scripts for the 0.35 release. |
Also delete the unlink scripts to move towards noarch (see the migration plan at conda-forge#111)
I deleted the unlink scripts in #144 (jlab 0.35). I think we probably can delete the link scripts and move to noarch in the next version, which will probably be maybe 10 months after notebook 5.3 was released? |
Sounds good, thanks! |
Oops, we should have done this for 1.0. I suppose we can do it for 1.1, though. I hesitate to make this change in a patch release, though. |
I'm doing a trial run of switching to the noarch package in the new prerelease branch. |
We can easily do this switch if we:
(Don't copy the prerelease branch |
We currently explicitly enable/disable the server extension in the link/unlink scripts. We should eventually transition to only using the conf.d approach (which already works), when we feel that enough time has passed that most people have upgraded to the relevant notebook version (I think 5.3, released in January 2018).
A transition plan is outlined in jupyter/notebook#3782 - which is complicated by the fact that we can't just do
jupyter serverextension uninstall
to remove the config entry. Basically, the transition plan involves removing the unlink scripts for several JupyterLab versions, so that most people have a jlab conda package that won't explicitly disable jlab on uninstall. Then remove the link scripts. The end result is that people will have a harmlessenable
entry in their notebook server config after upgrading, but installs into new environments will use the conf.d enabling only.The text was updated successfully, but these errors were encountered: