Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitioning to the conf.d enabling approach #111

Closed
jasongrout opened this issue Jul 19, 2018 · 9 comments · Fixed by #176
Closed

Transitioning to the conf.d enabling approach #111

jasongrout opened this issue Jul 19, 2018 · 9 comments · Fixed by #176

Comments

@jasongrout
Copy link
Contributor

jasongrout commented Jul 19, 2018

We currently explicitly enable/disable the server extension in the link/unlink scripts. We should eventually transition to only using the conf.d approach (which already works), when we feel that enough time has passed that most people have upgraded to the relevant notebook version (I think 5.3, released in January 2018).

A transition plan is outlined in jupyter/notebook#3782 - which is complicated by the fact that we can't just do jupyter serverextension uninstall to remove the config entry. Basically, the transition plan involves removing the unlink scripts for several JupyterLab versions, so that most people have a jlab conda package that won't explicitly disable jlab on uninstall. Then remove the link scripts. The end result is that people will have a harmless enable entry in their notebook server config after upgrading, but installs into new environments will use the conf.d enabling only.

@blink1073
Copy link
Member

👍

@jasongrout
Copy link
Contributor Author

jasongrout commented Jul 19, 2018

I propose that we start the transition by deleting the unlink scripts with the next version of JupyterLab, and wait at least 6 months (i.e., a year after notebook 5.3 was released) for people to move to these newer versions of JupyterLab and the notebook before deleting the link scripts.

@blink1073
Copy link
Member

Sounds good to me

@jasongrout
Copy link
Contributor Author

I propose that we start the transition by deleting the unlink scripts with the next version of JupyterLab, and wait at least 6 months (i.e., a year after notebook 5.3 was released) for people to move to these newer versions of JupyterLab and the notebook before deleting the link scripts.

Let's try to remember to delete the unlink scripts for the 0.35 release.

jasongrout added a commit to jasongrout/jupyterlab-feedstock that referenced this issue Oct 5, 2018
Also delete the unlink scripts to move towards noarch (see the migration plan at conda-forge#111)
@jasongrout jasongrout mentioned this issue Oct 5, 2018
5 tasks
@jasongrout
Copy link
Contributor Author

I deleted the unlink scripts in #144 (jlab 0.35). I think we probably can delete the link scripts and move to noarch in the next version, which will probably be maybe 10 months after notebook 5.3 was released?

@blink1073
Copy link
Member

Sounds good, thanks!

@jasongrout
Copy link
Contributor Author

Oops, we should have done this for 1.0. I suppose we can do it for 1.1, though. I hesitate to make this change in a patch release, though.

@jasongrout
Copy link
Contributor Author

I'm doing a trial run of switching to the noarch package in the new prerelease branch.

@jasongrout
Copy link
Contributor Author

We can easily do this switch if we:

  • copy the prerelease branch recipe meta.yaml to master
  • delete the scripts in the master recipe
  • rerender the recipe

(Don't copy the prerelease branch conda_build_config.yaml file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants