Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

howardhinnant_date v3.0.2 #18

Merged
merged 16 commits into from
Oct 17, 2024

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11308721920 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
jjerphan previously approved these changes Oct 14, 2024
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a priori even though a few elements of the project's build system and exposed configurations have changed in between both versions.

Waiting for someone else's approval before merging it.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the 3.0.2_hd139a6 branch 2 times, most recently from 9cdae7f to 7eb3878 Compare October 14, 2024 10:27
@apmorton
Copy link
Contributor

Maybe I missed something - but I don't see where the patch to locate the tzdb based on install prefix was upstreamed. I'd be surprised if it was honestly, it's a pretty conda-forge specific thing.

@jjerphan jjerphan dismissed their stale review October 14, 2024 14:13

tzdb patch in fact needs adaptation

@jjerphan
Copy link
Member

Thank you, @apmorton. 🙏

Feel free to finish this PR and subsequent ones.

@apmorton
Copy link
Contributor

Alright - I've clearly been barking up the wrong tree with the windows build error - will pick up tomorrow:

error LNK2019: unresolved external symbol "public: class date::time_zone const * __cdecl date::tzdb::locate_zone(class std::basic_string_view

I assumed this was because of something to do with HAS_STRING_VIEW being different between the build and the test - but I don't think that can be the case given the latest build failure.

@apmorton
Copy link
Contributor

HowardHinnant/date#850 - mystery solved - will fix up the test soon

@apmorton apmorton merged commit ae5a68a into conda-forge:main Oct 17, 2024
9 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 3.0.2_hd139a6 branch October 17, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants