-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
howardhinnant_date v3.0.2 #18
howardhinnant_date v3.0.2 #18
Conversation
…nda-forge-pinning 2024.10.12.13.15.35
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM a priori even though a few elements of the project's build system and exposed configurations have changed in between both versions.
Waiting for someone else's approval before merging it.
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
9cdae7f
to
7eb3878
Compare
Maybe I missed something - but I don't see where the patch to locate the tzdb based on install prefix was upstreamed. I'd be surprised if it was honestly, it's a pretty conda-forge specific thing. |
Thank you, @apmorton. 🙏 Feel free to finish this PR and subsequent ones. |
Alright - I've clearly been barking up the wrong tree with the windows build error - will pick up tomorrow:
I assumed this was because of something to do with |
HowardHinnant/date#850 - mystery solved - will fix up the test soon |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11308721920 - please use this URL for debugging.