Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python312 #69

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python312.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6269971942, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

I don't understand why meson wants to find distutils; meson itself should already be the right build backend...

../meson.build:20:15: ERROR: <PythonExternalProgram '$PREFIX/bin/python' -> ['$PREFIX/bin/python']> is not a valid python or it is missing distutils

A full log can be found at $SRC_DIR/forgebuild/meson-logs/meson-log.txt

@pkgw
Copy link
Contributor

pkgw commented Sep 24, 2023

Looks like mesonbuild/meson#7702 is the relevant upstream issue. I haven't actually sat down and digested the discussion there, though.

This is the current recommendation in mesonbuild/meson#7702 to deal with
Python 3.12's removal of distutils.
@pkgw
Copy link
Contributor

pkgw commented Sep 24, 2023

Looks like adding setuptools as a dep works around the issue, but then gobject-introspection itself depends on distutils, so we might need to add it as a runtime dep as well.

@h-vetinari
Copy link
Member

Yeah, but adding setuptools should not be necessary as meson itself is an equally (or even more) capable build system. For example, numpy & scipy build without issue on 3.12 with meson and without setuptools

@pkgw
Copy link
Contributor

pkgw commented Sep 24, 2023

Based on that Meson issue, my understanding is that Meson currently requires distutils for its Python support to work at all, though — apparently it's one of the few modules that Meson needs. From the Numpy build log, setuptools is getting pulled in as a dep in the 3.12 build, so it might be working coincidentally.

@pkgw
Copy link
Contributor

pkgw commented Sep 26, 2023

The Linux / Python 3.10 failure above looks spurious. The remaining Python 3.12 failures appear to be because gobject-introspection itself requires distutils, which I think at least could be worked around by adding a runtime dep on setuptools?

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Oct 2, 2023
@github-actions github-actions bot merged commit ca03064 into conda-forge:main Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python312-0-1_h999207 branch October 2, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants