Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure locales work #97

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jun 26, 2019

Applies the same changes we have in the ARM and POWER images to our other images to ensure the locales are working correctly.

Note: This also comes up in this SO answer.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Applies the same change we have in the POWER and ARM containers to our
other containers.
RUN yum update -y && \
yum reinstall -y glibc-common && \
yum clean all
RUN localedef -i en_US -f UTF-8 en_US.UTF-8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

kastman added a commit to psychopy-conda/staged-recipes that referenced this pull request Jun 27, 2019
kastman added a commit to psychopy-conda/staged-recipes that referenced this pull request Jun 27, 2019
kastman added a commit to psychopy-conda/staged-recipes that referenced this pull request Jun 27, 2019
@jakirkham jakirkham merged commit 260c85f into conda-forge:master Jun 27, 2019
@jakirkham jakirkham deleted the ensure_locales_work branch June 27, 2019 03:10
@jakirkham
Copy link
Member Author

Thanks for the review Marius! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants