-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Perl and R matrix items. #87
Handle Perl and R matrix items. #87
Conversation
Handle Perl and R matrix items.
Closes #82 by simply removing the appveyor.yml if it isn't needed. |
Nice, so we still register for AppVeyor, but simply don't include the CI file. Awesome fix. 👍 Just out of curiosity, under what conditions does it get added back? |
So, we tried removal of |
If your recipe no longer skips the specific windows matrix item, rerendering with conda-smithy (which anybody can do) will restore the |
There is a toggle which states |
Got it. That's what I was thinking. Thanks for clarifying.
Right, what would we need to do in order to get that to work? Is it possible to automate? |
Are you just planning to use this API? |
Yep |
So, I'm thinking about this again and I think we should just rename the CI file instead of deleting them so it is easy to get back. Mainly I am thinking about this in terms of PRs that want to add Windows support to something that didn't have it. For instance, we could move |
# There are no cases to build (not even a case without any special | ||
# dependencies), so remove the appveyor.yml if it exists. | ||
if os.path.exists(target_fname): | ||
os.remove(target_fname) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will probably just be changing this line honestly.
Proposal to rename AppVeyor CI files here ( #94 ). |
Not sure I agree with this statement (though I agree with your change in #94).
There are other projects out there who demand this kind of thing from their users, and expect the rendered content to be considered a black box (e.g. versioneer). Anyway, agree or not, the change you put forwards in #94 was a nice one 👍 |
Again, unittests would be great, but I have tested this by hand to confirm that this now enables Perl and R support to feedstocks.