Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily pin conda-build to 2.0.* #410

Closed
wants to merge 3 commits into from

Conversation

jakirkham
Copy link
Member

Encountering some strange test failures particularly on Python 2.7 since conda-build version 2.1.0 was released. This pins the conda-build 2 tests to 2.0.* to avoid these issues until we can properly address them. At present, these issues seem to only occur on the CIs and are not reproducible locally.

@jakirkham
Copy link
Member Author

@nicoddemus , seems pinning conda-build to 2.0.* "fixes" the problem. Not exactly what I would want to do. Sadly the error message is so terse I'm still not really sure what the error is. Not to mention I have been unable to reproduce this locally.

@nicoddemus
Copy link
Member

That's a bummer. Well, thanks for the info though. Let's see what we can discover in the next few days.

@isuruf
Copy link
Member

isuruf commented Jan 5, 2017

Note that py36 selector support is added in conda-build 2.1, so we might want to backport that if conda-build 2.0.* is pinned

@ocefpaf
Copy link
Member

ocefpaf commented Jan 5, 2017 via email

Encountering some strange test failures particularly on Python 2.7 since
`conda-build` version 2.1.0 was released. This pins the `conda-build` 2
tests to 2.0.* to avoid these issues until we can properly address them.
At present, these issues seem to only occur on the CIs and are not
reproducible locally.
@jakirkham
Copy link
Member Author

Have added a null change commit above so the error can be inspected.

Unfortunately there is not a clear traceback leading to conda-build. It was only noticed by inspecting to recent builds. This was meant as a test of that. So I wasn't going to bring him in until we had more information.

TBH the error looked like an issue with imports between Python 2/3. The fact that it is confined to Python 2.7 makes it more strange. This suggests to me that it may not even be a conda-build issue, but a conda-smithy issue that we have uncovered in the conda-build upgrade. So I had tried PR ( #410 ) to use absolute imports everywhere. That appears to have changed where the error comes from, but not the fact that there is one.

Have been unable to reproduce this locally either on my Mac or Linux. In any event, I would not worry about impact to conda-forge services as they all use Python 3.5, which doesn't experience this problem. I'm not even sure this pinning should be used outside of this CI until it can actually be confirmed as a elsewhere.

@jakirkham
Copy link
Member Author

After playing around with a few PRs, it does seem to be a conda-build issue after all. In particular, it is not installing enum34 on Python 2.7.

xref: conda/conda-build#1623

@jakirkham
Copy link
Member Author

Would rather just install enum34 on Python 2 CI builds near term until it gets sorted. So have added PR ( #414 ).

@jakirkham jakirkham deleted the pin_cb_20 branch January 6, 2017 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants