Use unicode on Python 2 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364
This uses UTF-8 in all cases. Files are opened with UTF-8 encoding and unicode literals are used throughout. Fixes some issues on Python 2 in particular where metadata from the recipe included unicode characters. This should now correctly support them. Have tested against the
pyemmafeedstock with both Python 2 and Python 3 locally. Works fine in both cases. Should add that this ends up already being well covered in the existing test suite thanks to the use of thetouch_filefunction, which had to receive a unicode literal to behave correctly.