Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix whitespace README template #326

Merged
merged 2 commits into from
Nov 5, 2016
Merged

fix whitespace README template #326

merged 2 commits into from
Nov 5, 2016

Conversation

shadowwalkersb
Copy link
Contributor

No description provided.

@jakirkham
Copy link
Member

Have you tried re-rendering with this? It may snatch up too much whitespace. Normally I try to pick one side for the - and then adjust other things to match.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a tweak to how whitespace is eliminated. Also please test this somewhere and demonstrate it works with a PR against a feedstock.

@@ -34,7 +34,7 @@ It is possible to list all of the versions of `{{ package.name() }}` available o
conda search {{ package.name() }} --channel {{ channel_name }}
```

{% if channel_name == 'conda-forge' %}
{%- if channel_name == 'conda-forge' -%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this isn't quite the right way to do this. It is eliminating all the whitespace between this and the next title. Would pick one side to - and then move this line up or down in the document accordingly to avoid further whitespace errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it in a new commit. Not quite how you requested. I removed both -s and an actual line below. When I have a single - as you suggested all 3 blank lines are removed. And we are after removing only 1 extra line. It seems to work for me locally, but, I can't do a demonstration with a PR.

@jakirkham jakirkham merged commit 2cc716a into conda-forge:master Nov 5, 2016
@jakirkham
Copy link
Member

Thanks @shadowwalkersb .

@shadowwalkersb shadowwalkersb deleted the fix-whitespace branch November 5, 2016 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants