Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_repo_root returns os.path.realpath #2220

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jan 15, 2025

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

Resolves macOS test failures uncovered in conda-feedstock & conda-build-feedstock downstream tests:

Since the CI doesn't test macOS I'm including screenshots showing I replicated the test failure on my local macOS and confirmed the fix:

Screenshot 2025-01-15 at 10 38 27 Screenshot 2025-01-15 at 10 38 49

@kenodegard kenodegard marked this pull request as ready for review January 15, 2025 16:46
@kenodegard kenodegard requested a review from a team as a code owner January 15, 2025 16:46
@beckermr beckermr merged commit f30e378 into conda-forge:main Jan 15, 2025
2 checks passed
@beckermr
Copy link
Member

thank you!

@kenodegard kenodegard deleted the fix-macos-path-comparision branch January 15, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants