Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH add py27 command #345

Merged
merged 3 commits into from
Mar 17, 2020
Merged

ENH add py27 command #345

merged 3 commits into from
Mar 17, 2020

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Mar 17, 2020 •
edited
Loading

Checklist

  • Pushed the branch to main repo
  • CI passed on the branch

@scopatz
Copy link
Member

scopatz commented Mar 17, 2020

It would be kinda cool if this were able to add any old version of Python, eg it also worked for 3.5. I don't think it would be a big modification to the PR.

@beckermr
Copy link
Member Author

@scopatz good to merge?

@beckermr
Copy link
Member Author

bump here @scopatz

@scopatz scopatz merged commit 0d75ebc into master Mar 17, 2020
@scopatz scopatz deleted the add-py2k branch March 17, 2020 22:04
@scopatz
Copy link
Member

scopatz commented Mar 17, 2020

Thanks!

@isuruf
Copy link
Member

isuruf commented Mar 17, 2020

You need to add c_compiler and vc entries and the zip_keys entry.

@beckermr
Copy link
Member Author

For windows sure, but we are deprecating vs2008 and we have trouble with those on azure, so I decided to punt.

isuruf
isuruf reviewed Mar 17, 2020
View reviewed changes
conda_forge_webservices/commands.py
"`conda-forge` provides no support for Python {pyver} "
"builds and "
"all builds are provided on an "
"\"as-is\" basis.\n".format(pyver=pyver)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add that win builds here are deprecated as vs2008 is not built anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yeah. Will make another pr.

This was referenced May 11, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beckermr @scopatz @isuruf