Loosen abseil run export #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Output of
|
xhochy
approved these changes
May 14, 2023
|
Is there something about not having a "." in the version? Would it need to be "20230125.*" instead of a bare "20230125"? The patches took hold but conda-forge/arrow-cpp-feedstock#1051 is still not resolving correctly, with an error that makes no sense to me. |
This was referenced May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global pinning for abseil is at
20230125, however our run-export in the package pinned to the minor version until just now.In combination with the fact that conda-forge/abseil-cpp-feedstock#58 updated to libabseil 20230125.2 and now packages have been built against that (with a run-export pinning to 20230125.2), a few environments cannot resolve anymore.
This is obviously not a great situation, but at least the pinning information isn't false to the best of my understanding. There should be no ABI breaks per "major" version (which abseil calls LTS).
I see two options:
I realize that this touches quite a few packages, but the change should be benign and have no further impact. Also, things look perhaps scarier than they are due to the huge amount of arrow builds (4-5 maintenance branches and frequently migrated), so a lot of the below is just arrow.
CC @conda-forge/core
Checklist
python show_diff.pyand posted the output as part of the PR.Footnotes
"fake" because that's migrating something already present in the pinning, and more specific than we'd need ↩