Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin py-lief<0.15 #236

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Pin py-lief<0.15 #236

merged 2 commits into from
Dec 11, 2024

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Dec 11, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

They are not compatible:

Traceback (most recent call last):
  File "/home/ubuntu/.pixi/envs/conda-build/bin/conda-build", line 7, in <module>
    from conda_build.cli.main_build import execute
  File "/home/ubuntu/.pixi/envs/conda-build/lib/python3.12/site-packages/conda_build/cli/main_build.py", line 19, in <module>
    from .. import api, build, source, utils
  File "/home/ubuntu/.pixi/envs/conda-build/lib/python3.12/site-packages/conda_build/build.py", line 54, in <module>
    from .post import (
  File "/home/ubuntu/.pixi/envs/conda-build/lib/python3.12/site-packages/conda_build/post.py", line 47, in <module>
    from .inspect_pkg import which_package
  File "/home/ubuntu/.pixi/envs/conda-build/lib/python3.12/site-packages/conda_build/inspect_pkg.py", line 28, in <module>
    from .os_utils.liefldd import codefile_class, machofile
  File "/home/ubuntu/.pixi/envs/conda-build/lib/python3.12/site-packages/conda_build/os_utils/liefldd.py", line 213, in <module>
    elf_dyn_tag=lief.ELF.DYNAMIC_TAGS.RUNPATH,
                ^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'lief._lief.ELF' has no attribute 'DYNAMIC_TAGS'

@xhochy
Copy link
Member Author

xhochy commented Dec 11, 2024

Corresponding repodata patch: conda-forge/conda-forge-repodata-patches-feedstock#926

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xhochy
Copy link
Member Author

xhochy commented Dec 11, 2024

@conda-forge/conda-build Ready for review.

@ocefpaf ocefpaf merged commit a3334dd into conda-forge:main Dec 11, 2024
27 checks passed
@xhochy xhochy deleted the pylief015 branch December 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants