Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pin on krb5, lmdbxx and cyrus-sasl #61

Merged
merged 12 commits into from
Sep 25, 2023
Merged

Remove pin on krb5, lmdbxx and cyrus-sasl #61

merged 12 commits into from
Sep 25, 2023

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Sep 21, 2023 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This extracts some of the changes proposed in #60.

@jjerphan
Remove pin on krb5, lmdb, lmdbxx, cyrus-sasl and fmt
0878e73 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
MNT: Re-rendered with conda-build 3.25.0, conda-smithy 3.26.2, and co…
b36f8b9 
…nda-forge-pinning 2023.09.21.07.24.16
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjerphan jjerphan mentioned this pull request Sep 21, 2023
Closed
@jjerphan jjerphan marked this pull request as ready for review September 21, 2023 12:12
@jjerphan
Update comment for Windows
4dffeb7 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
Unpin msgpack_c and correctly pin lmdb
6db2716 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan changed the title Remove pin on krb5, lmdb, lmdbxx, cyrus-sasl and fmt Remove pin on krb5, lmdbxx, cyrus-sasl and fmt Sep 21, 2023
@jjerphan
Copy link
Member Author

@conda-forge-admin, please rerender

jjerphan
jjerphan commented Sep 21, 2023
View reviewed changes
recipe/conda_build_config.yaml
Comment on lines +8 to +9
lmdb:
- 0.9.22
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: this is an alternative specification to make ArcticDB use LMDB 0.9.22.

Newer versions of LMDB could be used but they cause 1 parametrized tests out of 5000 to fail upstream. See: man-group/ArcticDB#437

This was referenced Sep 21, 2023
Merged
Merged
@jjerphan
Copy link
Member Author

jjerphan commented Sep 22, 2023 •
edited
Loading

The builds there are being tested by this companion PR upstream: man-group/ArcticDB#888.

JohanMabille
JohanMabille requested changes Sep 22, 2023
View reviewed changes
@jjerphan @JohanMabille
Specify the versions to use in the recipe instead
8be20ec 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
@jjerphan
Copy link
Member Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits September 22, 2023 07:43
MNT: Re-rendered with conda-build 3.26.1, conda-smithy 3.26.2, and co…
8c35697 
…nda-forge-pinning 2023.09.22.05.46.25
@jjerphan
Specify lmdb's version in the config for it to be picked
492bfc5 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
Copy link
Member Author

@conda-forge-admin, please rerender

@jjerphan jjerphan changed the title Remove pin on krb5, lmdbxx, cyrus-sasl and fmt Remove pin on krb5, lmdbxx and cyrus-sasl Sep 22, 2023
@jjerphan jjerphan changed the base branch from main to rc September 22, 2023 15:27
@jjerphan
Copy link
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/arcticdb-feedstock/actions/runs/6276196787.

@jjerphan
Copy link
Member Author

Rerendering after manually remerging rc into this branch:

@conda-forge-admin, please rerender

@jjerphan jjerphan added the automerge Merge the PR when CI passes label Sep 25, 2023
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Sep 25, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@jjerphan jjerphan added the automerge Merge the PR when CI passes label Sep 25, 2023
jjerphan added a commit to jjerphan/arcticdb-feedstock that referenced this pull request Sep 25, 2023
@jjerphan
Explicitly pin lmbdb 0.9.22
dd446d1 
See: conda-forge#61 (comment)

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@github-actions github-actions bot merged commit b271fa8 into conda-forge:rc Sep 25, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jjerphan jjerphan deleted the unpin branch September 25, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

@DerThorsten DerThorsten Awaiting requested review from DerThorsten DerThorsten is a code owner

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 is a code owner

@jamesmunro jamesmunro Awaiting requested review from jamesmunro jamesmunro is a code owner

@mehertz mehertz Awaiting requested review from mehertz mehertz is a code owner

@phoebusm phoebusm Awaiting requested review from phoebusm phoebusm is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars is a code owner

@qc00 qc00 Awaiting requested review from qc00 qc00 is a code owner

@vasil-pashov vasil-pashov Awaiting requested review from vasil-pashov vasil-pashov is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjerphan @JohanMabille