Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arcticdb v5.2.0 #382

Merged
merged 14 commits into from
Jan 27, 2025
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
libmongocxx 4.0.0-1 Anaconda-Server Badge
msgpack-c 7.0.0 Anaconda-Server Badge
protobuf 29.3 Anaconda-Server Badge

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12832181675 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 17, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12832555117. Examine the logs at this URL for more detail.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jjerphan
Copy link
Member

@conda-forge-admin, please rerender

@jjerphan jjerphan mentioned this pull request Jan 17, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12949708485. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might the error observed for osx i.e. (for osx_arm64):

  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): Needed DSO lib/libabsl_log_internal_check_op.2407.0.0.dylib found in ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4']
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): .. but ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): Needed DSO lib/libabsl_log_internal_message.2407.0.0.dylib found in ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4']
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): .. but ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): Needed DSO lib/libabsl_log_internal_nullguard.2407.0.0.dylib found in ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4']
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): .. but ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): Needed DSO lib/libabsl_hash.2407.0.0.dylib found in ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4']
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): .. but ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

be due to conda-forge/abseil-cpp-feedstock#87?

In the short term, we can try adding this to recipe/conda_build_config:

diff --git i/recipe/conda_build_config.yaml w/recipe/conda_build_config.yaml
index 5171a6e..ee3e634 100644
--- i/recipe/conda_build_config.yaml
+++ w/recipe/conda_build_config.yaml
@@ -1,3 +1,9 @@
+# Use clang and clang++ 17 due to ABI changes in abseil
+# See: https://github.com/conda-forge/abseil-cpp-feedstock/issues/87
+c_compiler_version:            # [osx]
+  - 17                         # [osx]
+cxx_compiler_version:          # [osx]
+  - 17                         # [osx]
 MACOSX_SDK_VERSION:        # [osx and x86_64]
   - "11.0"                 # [osx and x86_64]
 c_stdlib_version:          # [osx and x86_64]

and re-rendering.

@ognyanstoimenov
Copy link
Contributor

Might the error observed for osx i.e. (for osx_arm64):

  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): Needed DSO lib/libabsl_log_internal_check_op.2407.0.0.dylib found in ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4']
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): .. but ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): Needed DSO lib/libabsl_log_internal_message.2407.0.0.dylib found in ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4']
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): .. but ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): Needed DSO lib/libabsl_log_internal_nullguard.2407.0.0.dylib found in ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4']
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): .. but ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): Needed DSO lib/libabsl_hash.2407.0.0.dylib found in ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4']
  ERROR (arcticdb,lib/python3.11/site-packages/arcticdb_ext.cpython-311-darwin.so): .. but ['conda-forge/osx-arm64::libabseil==20240722.0=cxx17_h07bc746_4'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

be due to conda-forge/abseil-cpp-feedstock#87?

In the short term, we can try adding this to recipe/conda_build_config:

diff --git i/recipe/conda_build_config.yaml w/recipe/conda_build_config.yaml
index 5171a6e..ee3e634 100644
--- i/recipe/conda_build_config.yaml
+++ w/recipe/conda_build_config.yaml
@@ -1,3 +1,9 @@
+# Use clang and clang++ 17 due to ABI changes in abseil
+# See: https://github.com/conda-forge/abseil-cpp-feedstock/issues/87
+c_compiler_version:            # [osx]
+  - 17                         # [osx]
+cxx_compiler_version:          # [osx]
+  - 17                         # [osx]
 MACOSX_SDK_VERSION:        # [osx and x86_64]
   - "11.0"                 # [osx and x86_64]
 c_stdlib_version:          # [osx and x86_64]

and re-rendering.

I can try that but the linux is also failing

@ognyanstoimenov
Copy link
Contributor

@conda-forge-admin, please rerender

@jjerphan
Copy link
Member

jjerphan commented Jan 24, 2025

Yes, this is what I just have seen.

Something seems to overlinks with some of the shared object of libabseil via libprotobuf.

So in the short term we might assume that libabseil is a direct dependency of arcticdb by adding libabseil in the host section, making the shared objects available at runtime.

Gentle ping to @h-vetinari who is knowledgeable on libprotobuf and libabseil. 🙏

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12953004111. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12953010286. Examine the logs at this URL for more detail.

@ognyanstoimenov
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jjerphan
Copy link
Member

jjerphan commented Jan 24, 2025

As discussed with @phoebusm, if you want to add python 3.13 builds with this PR, you can copy .ci_support/migrations/python313.yaml from #364 here, and re-render again to generate .ci_support/*python3.13.____cpython.yaml files for the Python 3.13 builds.

One can also perform the numpy 2 migration similarly with .ci_support/migrations/numpy2.yaml from #353.


My two cents: if I were you, I would decouple step and perform them in this order:

@h-vetinari
Copy link
Member

This seems to be a failure that's pretty easy to fix:

==================================== ERRORS ====================================
_ ERROR collecting python/tests/stress/arcticdb/version_store/test_mem_leaks.py _
ImportError while importing test module '$SRC_DIR/python/tests/stress/arcticdb/version_store/test_mem_leaks.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
python/tests/stress/arcticdb/version_store/test_mem_leaks.py:572: in <module>
    from pytest_memray import Stack
E   ModuleNotFoundError: No module named 'pytest_memray'

What open questions regarding abseil/protobuf are there?

@ognyanstoimenov
Copy link
Contributor

@conda-forge-admin, please rerender

@jjerphan
Copy link
Member

jjerphan commented Jan 27, 2025

@h-vetinari: The error was different then (impromptu overlinkage with libabseil), but nevermind: this is probably more ArcticDB-related.

@ognyanstoimenov: conda-forge/memray-feedstock#44 needs to be merged so that pytest-memray is usable when running the tests.

Edit: it was merged and the workflows re-rendered.

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given 🟢 CI checks.

@ognyanstoimenov ognyanstoimenov merged commit 226a36f into conda-forge:main Jan 27, 2025
15 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 5.2.0_h8c6ba2 branch January 27, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants