Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark jupyter_client=6.1.13 as broken #253

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

davidbrochart
Copy link
Member

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

Checklist:

  • Make sure your package is in the right spot (broken/* for adding the
    broken label, not_broken/* for removing the broken label, or token_reset/*
    for token resets)
  • Added a description of the problem with the package in the PR description.
  • Added links to any relevant issues/PRs in the PR description.
  • Pinged the team for the package for their input.

Need to pin python >= 3.6
Related issue: jupyter/jupyter_client#634

@davidbrochart davidbrochart requested a review from a team as a code owner April 7, 2021 13:03
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package seems prominent enough that a repodata patch would be better.

@davidbrochart
Copy link
Member Author

But then we would have conda and PyPI out of sync, since we can't patch on PyPI?

@beckermr
Copy link
Member

beckermr commented Apr 7, 2021

Ah you removed the pypi release?

@davidbrochart
Copy link
Member Author

Not yet, but we have no choice but to yank the PyPI release.

@beckermr
Copy link
Member

beckermr commented Apr 7, 2021

OK. yanking releases is a last resort but sometimes needed. LGTM.

@beckermr beckermr merged commit 88904bc into conda-forge:master Apr 7, 2021
@davidbrochart davidbrochart deleted the jupyter_client branch April 7, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants