Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH migrator to cleanup appveyor feedstocks #18

Merged
merged 12 commits into from
Mar 23, 2020
Merged

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Mar 22, 2020

Guidelines and Ground Rules

  • Don't migrate more than several hundred feedstocks per hour.
  • Make sure to put [ci skip] [skip ci] [cf admin skip] ***NO_CI*** in any commits to
    avoid massive rebuilds.
  • Rate-limit commits to feedstocks to in order to reduce the load on our admin webservices.
  • Test your migration first. The https://github.com/conda-forge/cf-autotick-bot-test-package-feedstock is available to help test migrations.
  • CircleCI has a GITHUB_TOKEN in the environment. Please do not exhaust this
    token's API requests.
  • Do not rerender feedstocks!

Items 1-3 are taken care of by the migrations code assuming you don't make
any big changes.

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete appveyor projects?

@beckermr
Copy link
Member Author

We no longer register them on staged-recipes, so deleting ones where we have never built anything is consistent with our current policies.

@beckermr
Copy link
Member Author

Good catch. The other thing is that we went to prevent people from adding appveyor.

I need to do this for any feedstock without an .appveyor.yaml file.

@beckermr
Copy link
Member Author

We good to merge @isuruf ?

@beckermr
Copy link
Member Author

ok @isuruf ready for another look!

@isuruf
Copy link
Member

isuruf commented Mar 22, 2020

What's the motivation to delete these?

@beckermr
Copy link
Member Author

We need to prevent people from adding appveyor to any new feedstocks in order to finish CFEP-13. We cannot strip the option out of smithy and so that leaves us with two other options.

  1. Delete the projects on appveyor
  2. Remove the secure vars that allow uploading

Both are not great, but 1 seemed better since jobs wouldn't even start and so it errors sooner.

@beckermr
Copy link
Member Author

The second option won't actually work since people can copy-paste them or pull them out of the git history.

We could turn off the token, but that requires a big token migration which is also a huge pain.

@isuruf
Copy link
Member

isuruf commented Mar 22, 2020

We can just delete the token from anaconda.org

@beckermr
Copy link
Member Author

But that turns off everything since we use the same token

@beckermr
Copy link
Member Author

We will have to do that at the end, but I think we want a more staged approach.

Why do we care about the logs?

@isuruf
Copy link
Member

isuruf commented Mar 22, 2020

For some builds, I still compare builds to figure out what went wrong.

@isuruf
Copy link
Member

isuruf commented Mar 22, 2020

We can also set a setting on appveyor API to stop building pushes.

@beckermr
Copy link
Member Author

Ahhhh. Which setting is that? Happy to do that.

@isuruf
Copy link
Member

isuruf commented Mar 22, 2020

disablePushWebhooks: true

@beckermr
Copy link
Member Author

We should delete projects with no builds. Do you agree there?

@isuruf
Copy link
Member

isuruf commented Mar 22, 2020

Sure

@scopatz
Copy link
Member

scopatz commented Mar 22, 2020

Looks like there are conflicts here now

@beckermr
Copy link
Member Author

Yeah this pr needs work before merging. I’ll fix and ping y’all later.

@beckermr
Copy link
Member Author

OK @isuruf, ready for another look!

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I assume that you've checked that the API for getting the builds work.

@beckermr
Copy link
Member Author

Yeah, I have a notebook locally where it appears to be correct. I will double-check again to make sure.

@beckermr
Copy link
Member Author

Arggg. I had a bug or something. The code I just committed returned 10 for xonsh-feedstock and 0 for esutil-feedstock

@beckermr
Copy link
Member Author

I turned off the delete for now in favor of disabling everything @isuruf. We can delete them all later if we want

@isuruf
Copy link
Member

isuruf commented Mar 23, 2020

Thanks @beckermr.

@isuruf isuruf merged commit ee13f30 into master Mar 23, 2020
@beckermr
Copy link
Member Author

Ack. I found another bug. :/

Not a big deal, but will need fixing.

@isuruf isuruf deleted the appveyor-cleanup branch March 23, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants