-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH migrator to cleanup appveyor feedstocks #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why delete appveyor projects?
We no longer register them on staged-recipes, so deleting ones where we have never built anything is consistent with our current policies. |
Good catch. The other thing is that we went to prevent people from adding appveyor. I need to do this for any feedstock without an .appveyor.yaml file. |
We good to merge @isuruf ? |
ok @isuruf ready for another look! |
What's the motivation to delete these? |
We need to prevent people from adding appveyor to any new feedstocks in order to finish CFEP-13. We cannot strip the option out of smithy and so that leaves us with two other options.
Both are not great, but 1 seemed better since jobs wouldn't even start and so it errors sooner. |
The second option won't actually work since people can copy-paste them or pull them out of the git history. We could turn off the token, but that requires a big token migration which is also a huge pain. |
We can just delete the token from anaconda.org |
But that turns off everything since we use the same token |
We will have to do that at the end, but I think we want a more staged approach. Why do we care about the logs? |
For some builds, I still compare builds to figure out what went wrong. |
We can also set a setting on appveyor API to stop building pushes. |
Ahhhh. Which setting is that? Happy to do that. |
|
We should delete projects with no builds. Do you agree there? |
Sure |
Looks like there are conflicts here now |
Yeah this pr needs work before merging. I’ll fix and ping y’all later. |
OK @isuruf, ready for another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I assume that you've checked that the API for getting the builds work.
Yeah, I have a notebook locally where it appears to be correct. I will double-check again to make sure. |
Arggg. I had a bug or something. The code I just committed returned 10 for xonsh-feedstock and 0 for esutil-feedstock |
I turned off the delete for now in favor of disabling everything @isuruf. We can delete them all later if we want |
Thanks @beckermr. |
Ack. I found another bug. :/ Not a big deal, but will need fixing. |
Guidelines and Ground Rules
[ci skip] [skip ci] [cf admin skip] ***NO_CI***
in any commits toavoid massive rebuilds.
https://github.com/conda-forge/cf-autotick-bot-test-package-feedstock
is available to help test migrations.GITHUB_TOKEN
in the environment. Please do not exhaust thistoken's API requests.
Items 1-3 are taken care of by the migrations code assuming you don't make
any big changes.