Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load FROM images as inputs without fetching #1

Closed
vito opened this issue Aug 27, 2019 · 0 comments · Fixed by #52
Closed

Load FROM images as inputs without fetching #1

vito opened this issue Aug 27, 2019 · 0 comments · Fixed by #52

Comments

@vito
Copy link
Member

vito commented Aug 27, 2019

Equivalent to docker-image resource's load_bases.

Dependent on moby/buildkit#706
This was referenced Aug 27, 2019
Closed
Closed
Closed
Closed
@mgsolid mgsolid mentioned this issue Nov 6, 2019
Closed
@jgriff jgriff mentioned this issue Feb 17, 2020
Closed
@vlfig vlfig mentioned this issue Jul 7, 2020
Closed
@vito vito mentioned this issue Aug 13, 2020
Open
@vito vito mentioned this issue Nov 23, 2020
Open
vito added a commit that referenced this issue Jan 8, 2021
@vito
support using local image tarballs with FROM
bb2f5be 
This adds 'image args', configurable with IMAGE_ARG_* - similar to
BUILD_ARG_*, only the value points to an image tarball.

The image tarball will be loaded and served by a local registry, and a
reference to the image in the local registry will be provided as the
build arg.

To use this, you must modify your Dockerfile like so:

  ARG base_image=ubuntu
  FROM ${base_image}

Then, when running oci-build-task, specify:

  params:
    IMAGE_ARG_base_image: ubuntu/image.tar

This will remain forward compatible if we ever switch to Kaniko (#46),
which would also require using build args as Kaniko image caching
requires a full digest to be specified in FROM.

fixes #1
closes #2
closes #3
closes #14

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
@vito vito mentioned this issue Jan 8, 2021
Merged
@vito vito closed this as completed in #52 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support using local image tarballs with FROM concourse/oci-build-task
1 participant
@vito