Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fly command and api endpoint for request schedule on job #4863

Merged
merged 5 commits into from
Jan 2, 2020

Conversation

julia-pu
Copy link
Contributor

@julia-pu julia-pu commented Dec 6, 2019

implements #4820

added fly command and api endpoint for manually requesting schedule on a specific job.

@julia-pu julia-pu requested review from a team December 6, 2019 19:30
Signed-off-by: Julia Pu <jpu@pivotal.io>
Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call the command and API just "schedule job" instead? The 'request' is being made by running the command or hitting the API in the first place so I don't think we need the extra word.

Signed-off-by: Julia Pu <jpu@pivotal.io>
@julia-pu julia-pu requested a review from vito December 12, 2019 15:32
[#4820]

Signed-off-by: Clara Fu <cfu@pivotal.io>
[#4820]

Signed-off-by: Clara Fu <cfu@pivotal.io>
@vito vito changed the base branch from manually-trigger-fix to release/6.0.x January 2, 2020 19:41
@vito vito merged commit cdd3c80 into release/6.0.x Jan 2, 2020
@vito vito deleted the fly-job-scheduling branch January 2, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants