Rerun build inputs and pipes should make inputs ready be true #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adopting rerun build inputs and pipes should also flip inputs ready to be true. Signed-off-by: Clara Fu <cfu@pivotal.io>
vito
approved these changes
Nov 19, 2019
This test is unnecessary because it is tested within the pipeline factory tests for PipelinesToSchedule. Also fixed a missing error check in the tests. Signed-off-by: Clara Fu <cfu@pivotal.io> Co-authored-by: Julia Pu <jpu@pivotal.io>
create local error vars within each go routine in the scheduler Signed-off-by: Clara Fu <cfu@pivotal.io> Co-authored-by: Julia Pu <jpu@pivotal.io>
If we fly sync within the test, it actually affects the fly binary that is possibly used by multiple tests because it points to the same path. The test is changed to create a new fly binary for the fly sync test in order to avoid that. Signed-off-by: Clara Fu <cfu@pivotal.io> Co-authored-by: Alex Suraci <suraci.alex@gmail.com> Signed-off-by: Clara Fu <cfu@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopting rerun build inputs and pipes should also flip inputs ready to
be true.
Contributor Checklist
Reviewer Checklist
and Helm packaging; otherwise, ignored for the integration tests (for example, if they are Garden configs that are not displayed in the
--helptext).