-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance / dependency update #338
Conversation
…dir [PT-186622946] Cypress has a bug that breaks tests that import files imported from outside the Cypress folder when TypeScript 5+ is used: cypress-io/cypress#26203 These tests were currently skipped anyway, so moving them out of the basic dir so Cypress doesn't even try to run them and fail because of the sourceMap issue. Hopefully, this Cypress bug gets fixed before we will have time to re-enable these tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
In CODAP, I created a cypress-specific
|
Right, I've seen this recommended as a workaround in the Cypress bug thread. I've tried it, but it didn't help in this case. It seems that the main tsconfig.json is being picked up anyway. Moreover, looking at the Cypress bug thread, it appears I'm not the only one experiencing this issue. To provide more details: this bug occurs only in tests that import code from outside the Cypress directory (like helpers, types). Tests contained within Cypress dir work fine, with or without this local, Cypress-specific tsconfig.json. I believe this is the reason (could it be the monorepo setup? However, that seems less likely). |
This PR updates as many dependencies as possible within a reasonable time frame. Note that there is a Cypress bug that causes some tests to fail when using TypeScript v5+ (cypress-io/cypress#26203). Consequently, I relocated some tests out of the basic directory. However, all of these tests were already being skipped. With Cypress v13, the tests that are currently in use now work.
Dependencies in tecrock-table and shared packages have also been updated. I mostly had to skip updating React or React types, as these updates cause issues with the question-interactives-helpers dependency, which we import in an unconventional manner (by directly reading the source from the package).