-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROSEnv example #164
Add ROSEnv example #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few minor possible improvements to the C++ contents, but the overall flow looks good.
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better and simpler with fmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can merge just right before merging conan-io/docs#3891
* rosenv example * missing files * changes * add to readme * add docker ci for the example * fix * fix * Update examples/tools/ros/rosenv/workspace/consumer/CMakeLists.txt Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> * update example * Update examples/tools/ros/rosenv/workspace/consumer/CMakeLists.txt * test in github actions * use bash * fix cd * wip * Update examples/tools/README.md Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> * Update .github/workflows/ros-tests.yml * add develop2 testing * wip * wip * minor changes * wip --------- Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
* wip CI * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * review * review * wip * moved * wip * Fixed import (#165) * Add ROSEnv example (#164) * rosenv example * missing files * changes * add to readme * add docker ci for the example * fix * fix * Update examples/tools/ros/rosenv/workspace/consumer/CMakeLists.txt Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> * update example * Update examples/tools/ros/rosenv/workspace/consumer/CMakeLists.txt * test in github actions * use bash * fix cd * wip * Update examples/tools/README.md Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> * Update .github/workflows/ros-tests.yml * add develop2 testing * wip * wip * minor changes * wip --------- Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> * review * Update ci/game/project_setup.py --------- Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> Co-authored-by: Francisco Ramírez <franchuti688@gmail.com> Co-authored-by: Daniel <danimanzaneque@gmail.com>
Related to: