Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROSEnv example #164

Merged
merged 22 commits into from
Nov 14, 2024
Merged

Add ROSEnv example #164

merged 22 commits into from
Nov 14, 2024

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Oct 23, 2024

@danimtb danimtb self-assigned this Oct 23, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

@czoido czoido self-assigned this Oct 23, 2024
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few minor possible improvements to the C++ contents, but the overall flow looks good.

examples/tools/ros/rosenv/workspace/consumer/src/hello.cpp Outdated Show resolved Hide resolved
examples/tools/ros/rosenv/workspace/app/CMakeLists.txt Outdated Show resolved Hide resolved
examples/tools/ros/rosenv/workspace/app/src/main.cpp Outdated Show resolved Hide resolved
danimtb and others added 2 commits October 28, 2024 10:45
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better and simpler with fmt

@danimtb danimtb marked this pull request as ready for review October 30, 2024 07:44
examples/tools/README.md Outdated Show resolved Hide resolved
czoido and others added 4 commits November 4, 2024 08:38
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Copy link
Member Author

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

Copy link
Contributor

@czoido czoido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge just right before merging conan-io/docs#3891

@czoido czoido merged commit be895a1 into main Nov 14, 2024
4 checks passed
memsharded pushed a commit to memsharded/examples2 that referenced this pull request Nov 25, 2024
* rosenv example

* missing files

* changes

* add to readme

* add docker ci for the example

* fix

* fix

* Update examples/tools/ros/rosenv/workspace/consumer/CMakeLists.txt

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* update example

* Update examples/tools/ros/rosenv/workspace/consumer/CMakeLists.txt

* test in github actions

* use bash

* fix cd

* wip

* Update examples/tools/README.md

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Update .github/workflows/ros-tests.yml

* add develop2 testing

* wip

* wip

* minor changes

* wip

---------

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
czoido added a commit that referenced this pull request Dec 10, 2024
* wip CI

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* review

* review

* wip

* moved

* wip

* Fixed import (#165)

* Add ROSEnv example (#164)

* rosenv example

* missing files

* changes

* add to readme

* add docker ci for the example

* fix

* fix

* Update examples/tools/ros/rosenv/workspace/consumer/CMakeLists.txt

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* update example

* Update examples/tools/ros/rosenv/workspace/consumer/CMakeLists.txt

* test in github actions

* use bash

* fix cd

* wip

* Update examples/tools/README.md

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Update .github/workflows/ros-tests.yml

* add develop2 testing

* wip

* wip

* minor changes

* wip

---------

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* review

* Update ci/game/project_setup.py

---------

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants