Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for replace_requires, replace_tool_requires, platform_requires and platform_tool_requires profile sections #3495

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Dec 19, 2023

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the feature needs a bit more of explanation, some important points:

  • This is a literal replacement of requires in recipes, as the very first step before any other processing of requirements, without any further processing of conflicts, etc
  • Put a Best practices section saying that this is not to be abused, this is not a versioning mechanism, this is for exceptional cases to temporarily solve conflicts or to replace one certain dependency for a system one in some cross-build scenarios

reference/config_files/profiles.rst Show resolved Hide resolved
reference/config_files/profiles.rst Show resolved Hide resolved
reference/config_files/profiles.rst Outdated Show resolved Hide resolved
reference/config_files/profiles.rst Show resolved Hide resolved
@danimtb danimtb marked this pull request as ready for review December 19, 2023 13:10
@danimtb danimtb changed the title Docs for replace_requires and replace_tool_requires profile sections Docs for replace_requires, replace_tool_requires, platform_requires and platform_tool_requires profile sections Dec 19, 2023
Copy link
Contributor

@czoido czoido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments, but looks good!

danimtb and others added 3 commits December 19, 2023 17:19
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
@czoido czoido merged commit 6376205 into conan-io:develop2 Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants