-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for replace_requires, replace_tool_requires, platform_requires and platform_tool_requires profile sections #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the feature needs a bit more of explanation, some important points:
- This is a literal replacement of
requires
in recipes, as the very first step before any other processing of requirements, without any further processing of conflicts, etc - Put a
Best practices
section saying that this is not to be abused, this is not a versioning mechanism, this is for exceptional cases to temporarily solve conflicts or to replace one certain dependency for a system one in some cross-build scenarios
danimtb
changed the title
Docs for replace_requires and replace_tool_requires profile sections
Docs for replace_requires, replace_tool_requires, platform_requires and platform_tool_requires profile sections
Dec 19, 2023
memsharded
approved these changes
Dec 19, 2023
czoido
reviewed
Dec 19, 2023
czoido
reviewed
Dec 19, 2023
czoido
reviewed
Dec 19, 2023
czoido
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments, but looks good!
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for conan-io/conan#15136 and conan-io/conan#14871