Revert changes from PR 7586 #7638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Sep 2, 2020
|
cc / @SSE4 We are reverting this, this is breaking the 1.29 release, changing the default profile to use MinGW in windows |
|
okay, I'll take a look into Windows part, shouldn't be too complicated |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: omit
Docs: omit
This PR reverts the changes from: #7586
It was necessary as this test: https://github.com/conan-io/test/blob/master/conan_tests/external_tools/meson_test.py was failing for Windows.
The reason is that if
ccorc++are in the path in Windows they will be detected as the default compilers and this changes the behaviour from previous versions. We are reverting this for the moment and will be testing the compiler auto-detection further.