Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan 1.x: Add apple-clang 16 to settings #16980

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Sep 11, 2024

Changelog: Feature: Conan 1.x: Add apple-clang 16 to settings
Docs: conan-io/docs#3837

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

similar to:

cc @czoido

@chenrui333 chenrui333 changed the base branch from develop2 to develop September 11, 2024 18:41
Signed-off-by: Rui Chen <rui@chenrui.dev>
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Adding new things to Conan 1 settings is a bit more complex, it requires fixing some migration stuff. We can help with that.

However, the release pace of Conan 1.X nowadays is much slower, it might take a while until next Conan 1.X release with this happens.

@chenrui333
Copy link
Contributor Author

I thought this is more of a settings config change? looks like the patch works for me on the homebrew build/test side.

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort! 😄

@memsharded memsharded added this to the 1.66.0 milestone Sep 17, 2024
@ErniGH ErniGH merged commit 8455c2c into conan-io:develop Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants