Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need return 3 None on detect_default_compiler() to avoid errors #15832

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: need return 3 None on detect_default_compiler() to avoid errors #15832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c6c7c
fix: need return 3 None on detect_default_compiler() to avoid errors …
ErniGH Mar 7, 2024
f775c40
keep the return to simplify the flow
ErniGH Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion conan/internal/api/detect_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,12 +397,13 @@ def detect_default_compiler():
clang, clang_version, compiler_exe = _clang_compiler() # prioritize clang
if clang:
return clang, clang_version, compiler_exe
return
AbrilRBS marked this conversation as resolved.
Show resolved Hide resolved
return None, None, None
else:
gcc, gcc_version, compiler_exe = _gcc_compiler()
if gcc:
return gcc, gcc_version, compiler_exe
return _clang_compiler()
return None, None, None


def default_msvc_ide_version(version):
Expand Down