Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy usage of update arg in conan api #15743

Merged

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Feb 22, 2024

Changelog: Bugfix: Fix legacy usage of update argument in Conan API.
Docs: Omit

In #15652 we moved from passing a boolean to the update argument for graph loading to a list of references - While we tested that no Conan code was using the old syntax, I forgot to take into account that this would be used by other people directly from the API, which even if not properly documented yet, has valid usages outside our control

This PR ensures that old behaviour for the API is respected - to be released as 2.1.1 probably

Closes #15742

@AbrilRBS AbrilRBS changed the base branch from develop2 to release/2.1 February 22, 2024 20:26
@memsharded memsharded added this to the 2.2.0 milestone Feb 22, 2024
@AbrilRBS AbrilRBS changed the base branch from release/2.1 to develop2 February 22, 2024 20:59
@memsharded memsharded merged commit 97056b0 into conan-io:develop2 Feb 23, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the rr/hotfix-update-legacy-usage-2.1 branch February 23, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Computing dependency graph fails due to iterating over a boolean
2 participants