Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Added env variable to append other custom command location #15436

Merged

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Jan 10, 2024

Changelog: omit
Docs: omit

…ppend custom commands location to the Conan one
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

conan/cli/cli.py Show resolved Hide resolved
Copy link
Contributor Author

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@memsharded @RubenRBS @czoido

The order is confusing but it's fine as it is, and the test is already checking that. I just added a comment to explain better what's happening under the hood. Basically, we're using sys.path.append, so the developer ones will have preference over any other custom commands defined.

@czoido czoido merged commit 40c3d99 into conan-io:release/2.0 Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants