Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport <host_version:track ref> to Conan v1 #15287

Merged

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Dec 17, 2023

Changelog: Feature: Add tracking of different ref to <host_version>.
Changelog: Bugfix: Make <host_version> only track for same user/channel.
Docs: conan-io/docs#3575

Need to check with the team if we want the bugfix. Conan v2 behaves similarly

@AbrilRBS AbrilRBS added this to the 1.63 milestone Dec 17, 2023
@AbrilRBS AbrilRBS requested a review from memsharded December 17, 2023 18:33
@SSE4
Copy link
Contributor

SSE4 commented Dec 26, 2023

what is track ref in the first place? searching in conan docs provides zero results for that term. and why is it needed to be added to 1.x?

@AbrilRBS
Copy link
Member Author

what is track ref in the first place?

You're right that the PR title is not the most obvious thing (Note that the proper changelog goes into the Changelog entry in the PR body which I think does make sense) - It's meant to represent the ability to track a different ref other than the one being required in the <host_version> instance.

and why is it needed to be added to 1.x?

We need to add this to V1 because CCI needs this fix for libgettext/gettext - and as we're still building v1 & v2 there, backporting this made sense :)

@SSE4
Copy link
Contributor

SSE4 commented Dec 26, 2023

We need to add this to V1 because CCI needs this fix for libgettext/gettext - and as we're still building v1 & v2 there, backporting this made sense :)

it's still not clear from the PR body Changelog entry, which says Bugfix: Make <host_version> only track for same user/channel. AFAIK CCI doesn't use username and channel at all, so it's unclear what exactly does it fix in the context of CCI.

IMO it needs more explanation of the use-case to make it crystal clear (what's the problem are we trying to solve, what's the command line, and some example how to use host_version:track ref in the recipe).

e.g. from PR diff it looks like tests are using syntax self.tool_requires("protobuf/<host_version>@tool_requires_tag"), while PR title states it should be self.tool_requires("protobuf/<host_version>:tool_requires_tag"), which is confusing right now.

to add more to confusion, PR title uses term ref (I assume short for reference), while code uses term tag for some reason, while in reality it's just username/channel in tests (could it be a full package or recipe reference here? unclear).

@memsharded memsharded merged commit 9f13832 into conan-io:develop Dec 27, 2023
2 checks passed
@AbrilRBS AbrilRBS deleted the rr/backport-host_version-lib-track branch December 27, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants