Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new lock remove command #15284

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Dec 16, 2023

Changelog: Feature: New conan lock remove command to remove requires from lockfiles.
Docs: conan-io/docs#3496

I am proposing this PR to close:

Close #14523
Close #14524

The idea is that updates are equivalent to something like:

$ conan remove --requires=zlib/* && conan add --requires=zlib/1.2.11

But it will allow us to first iterate and learn about the logic of removal of versions from lockfiles, because conan remove makes sense in isolation, even without lock update or lock add, like for example using it before resolving it to latest with --lockfile-partial. When we have clear what is the UX and UI for the removal, we can do a single command conan update or conan add with extra arguments

@memsharded memsharded added this to the 2.0.15 milestone Dec 16, 2023
@memsharded memsharded requested a review from jcar87 December 16, 2023 10:42
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only have 1 doubt about a pattern case, otherwise looks good to me

@czoido czoido merged commit d08fbe0 into conan-io:release/2.0 Dec 19, 2023
2 checks passed
@memsharded memsharded deleted the feature/lock_remove branch December 19, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants