Add core:warnings_as_errors configuration option
#15149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Nov 21, 2023
memsharded
reviewed
Dec 18, 2023
conan/internal/deploy.py
Outdated
| @@ -77,7 +77,7 @@ def _deploy_single(dep, conanfile, output_folder, folder_name): | |||
| except Exception as e: | |||
| if "WinError 1314" in str(e): | |||
| ConanOutput().error("full_deploy: Symlinks in Windows require admin privileges " | |||
| "or 'Developer mode = ON'") | |||
| "or 'Developer mode = ON'", error_type="context") | |||
There was a problem hiding this comment.
What is a "context" error? The meaning is not evident to me
memsharded
reviewed
Dec 18, 2023
4bff9ee to
974b568
Compare
memsharded
approved these changes
Dec 18, 2023
memsharded
approved these changes
Dec 18, 2023
franramirez688
approved these changes
Dec 18, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add
core:warnings_as_errorsconfiguration option to make Conan raise on warnings and errors.Docs: conan-io/docs#3484
First try for
core:warnings_as_errors. It worries me that people might want to have Conan stop processing on errors in this case (We mostly do that now when we print proper errors as they are next to raised exceptions), but I'm not quite sure if I should just raise here too. Any opinions are welcomed :)Closes #14909